Enable pubkey lookup for p2sh-p2wpkh in validateaddress #8992

pull instagibbs wants to merge 2 commits into bitcoin:master from instagibbs:validatep2pkh changing 1 files +9 −0

instagibbs commented at 8:04 PM on October 21, 2016: member

When we ever switch to p2sh-p2pkh this will be useful for general wallet usage, as well as adapting tests where retrieving the pubkeys for standard addresses is important.
Enable pubkey lookup for p2sh-p2wpkh in validateaddress 3d2db70980

in src/rpc/misc.cpp:None in 3d2db70980 outdated

 140 | +                std::vector<unsigned char> witnessprogram;
 141 | +                subscript.IsWitnessProgram(witnessversion, witnessprogram);
 142 | +                CPubKey vchPubKey;
 143 | +                if (pwalletMain->GetPubKey(CKeyID(uint160(witnessprogram)), vchPubKey)) {
 144 | +                    obj.push_back(Pair("pubkey", HexStr(vchPubKey)));
 145 | +                    obj.push_back(Pair("iscompressed", vchPubKey.IsCompressed()));

jl2012 commented at 8:50 PM on October 21, 2016:

Signing and watching with segwit uncompressed keys are already disabled. I think the results should be suppressed if the key is not compressed.

fanquake added the label RPC/REST/ZMQ on Oct 22, 2016
supress uncompressed segwit pubkeys 981af939e8
instagibbs commented at 1:46 PM on October 24, 2016: member

@jl2012 suppressed uncompressed pubkeys and removed the iscompressed field
luke-jr referenced this in commit 4762f19400 on Dec 21, 2016
luke-jr referenced this in commit f2eb1cf077 on Dec 21, 2016
instagibbs commented at 6:28 PM on January 4, 2017: member

Closing in favor of https://github.com/bitcoin/bitcoin/pull/9017
instagibbs closed this on Jan 4, 2017
MarcoFalke locked this on Sep 8, 2021

Contributors

instagibbs

jl2012

Labels

RPC/REST/ZMQ

Linked (view graph)

#9017 Enable various p2sh-p2wpkh functionality