Enable pubkey lookup for p2sh-p2wpkh in validateaddress #8992

1. 
   instagibbs commented at 8:04 pm on October 21, 2016: member

   When we ever switch to p2sh-p2pkh this will be useful for general wallet usage, as well as adapting tests where retrieving the pubkeys for standard addresses is important.
2. Enable pubkey lookup for p2sh-p2wpkh in validateaddress 3d2db70980
3. in src/rpc/misc.cpp: in 3d2db70980 outdated

   140+                std::vector<unsigned char> witnessprogram;
   141+                subscript.IsWitnessProgram(witnessversion, witnessprogram);
   142+                CPubKey vchPubKey;
   143+                if (pwalletMain->GetPubKey(CKeyID(uint160(witnessprogram)), vchPubKey)) {
   144+                    obj.push_back(Pair("pubkey", HexStr(vchPubKey)));
   145+                    obj.push_back(Pair("iscompressed", vchPubKey.IsCompressed()));
   

   ---

   ---

   

   jl2012 commented at 8:50 pm on October 21, 2016:

   Signing and watching with segwit uncompressed keys are already disabled. I think the results should be suppressed if the key is not compressed.
4. fanquake added the label RPC/REST/ZMQ on Oct 22, 2016
5. supress uncompressed segwit pubkeys 981af939e8
6. 
   instagibbs commented at 1:46 pm on October 24, 2016: member

   @jl2012 suppressed uncompressed pubkeys and removed the iscompressed field
7. luke-jr referenced this in commit 4762f19400 on Dec 21, 2016
8. luke-jr referenced this in commit f2eb1cf077 on Dec 21, 2016
9. 
   instagibbs commented at 6:28 pm on January 4, 2017: member

   Closing in favor of https://github.com/bitcoin/bitcoin/pull/9017
10. instagibbs closed this on Jan 4, 2017

    ---

11. MarcoFalke locked this on Sep 8, 2021

Contributors
instagibbs jl2012

Labels
RPC/REST/ZMQ