Simplify MyGetSpecialFolderPath and fix possible buffer overflow (#901) #902

pull laanwj wants to merge 1 commits into bitcoin:master from laanwj:2012_02_getspecialfolderpath_overflow changing 1 files +10 −33

laanwj commented at 4:15 PM on February 26, 2012: member

Removes potential buffer overflow in win32 code as reported in #901.

Also simplify the MyGetSpecialFolderPath function, as SHGetSpecialFolderPath is always included in Windows XP, the minimum version supported by bitcoin: http://msdn.microsoft.com/en-us/library/windows/desktop/bb762204%28v=vs.85%29.aspx

Warning: Untested
Simplify MyGetSpecialFolderPath and fix possible buffer overflow (#901) 21ae37d215
sipa commented at 12:41 AM on February 27, 2012: member

ACK; it compiles at least; have not tried running it in windows
sipa commented at 2:20 PM on February 28, 2012: member

Seems to work under Wine.
gavinandresen merged this on Feb 28, 2012
gavinandresen closed this on Feb 28, 2012
laanwj deleted the branch on Apr 9, 2014
suprnurd referenced this in commit 9cb4dfca79 on Dec 5, 2017
ptschip referenced this in commit 1b39d15682 on Jan 11, 2018
lateminer referenced this in commit 8adeeb9727 on Oct 30, 2019
DrahtBot locked this on Sep 8, 2021

Contributors