keypoololdest is seconds since Unix epoch, not "GMT epoch" as was previously written
Resources: https://bitcointalk.org/index.php?topic=4451.0 http://bitcoin.stackexchange.com/questions/35913/what-does-the-keypoololdest-field-mean
keypoololdest denote Unix epoch, not GMT #9041
pull smatthewenglish wants to merge 1 commits into bitcoin:master from smatthewenglish:patch-8 changing 2 files +2 −2-
smatthewenglish commented at 1:27 PM on October 30, 2016: contributor
-
MarcoFalke commented at 1:38 PM on October 30, 2016: member
@s-matthew-english Did you know you can use
$ git grep keypoololdestto see if there are other affected rpcs, so all of them can be fixed in one go? - MarcoFalke added the label Docs and Output on Oct 30, 2016
- MarcoFalke added the label RPC/REST/ZMQ on Oct 30, 2016
-
smatthewenglish commented at 2:02 PM on October 30, 2016: contributor
ahh, yeah I mean, I knew of 'grep' but I didn't use it before really. at the moment I'm tied up, but definetly later tonight I can and will do that, but- if you don't mind, could I try to do it myself so I can get some experience with that?
- smatthewenglish force-pushed on Oct 31, 2016
-
Change all instance of 'GMT epoch' to 'Unix epoch' 7f61b49de8
- smatthewenglish force-pushed on Oct 31, 2016
-
smatthewenglish commented at 12:14 AM on October 31, 2016: contributor
alright, great!
I've grepped for 'GMT epoch' and I spotted another one in "src/wallet/rpcwallet.cpp", so now I've changed that one too.
I commited everything according to that discussion we had last time so- I think I did it right. Is it so?
-
MarcoFalke commented at 9:50 AM on October 31, 2016: member
utACK 7f61b49de82989dc692e7750860eb1ec4044db7a, I think both describe the same thing, but it can't hurt...
-
sipa commented at 6:24 PM on October 31, 2016: member
They do mean the same thing, but I think that Unix epoch is less ambiguous.
- MarcoFalke merged this on Oct 31, 2016
- MarcoFalke closed this on Oct 31, 2016
- MarcoFalke referenced this in commit 3d69ecb4ed on Oct 31, 2016
- luke-jr referenced this in commit 87fbcede5c on Dec 2, 2016
- codablock referenced this in commit e51cbae75d on Sep 19, 2017
- codablock referenced this in commit ade67c91e7 on Jan 13, 2018
- andvgal referenced this in commit f81f59b9f0 on Jan 6, 2019
- CryptoCentric referenced this in commit 78fa614934 on Feb 15, 2019
- DrahtBot locked this on Sep 8, 2021
Contributors
Labels