net: make a few values immutable, and use deterministic randomness for the localnonce #9050

1. 
   theuni commented at 10:02 pm on October 31, 2016: member

   As briefly discussed in #8708 (which conflicts here, I’ll fix one up post-merge of the other). @sipa is siphash of a single incrementing int strong enough here for preventing fingerprinting?
2. net: constify a few CNode vars to indicate that they're threadsafe aff6584e09
3. net: Use deterministic randomness for CNode's nonce, and make it const 59ac5c5b72
4. 
   theuni commented at 10:39 pm on October 31, 2016: member

   As discussed on IRC, Travis failure unrelated.
5. 
   MarcoFalke commented at 10:28 am on November 1, 2016: member

   Rerun and archived failure here:

   0test count = ../../../src/secp256k1/src/tests.c64
   1random seed = 803fa67dcab64b4b14a4c0089a34e7b6
   2:393: test condition failed: ((~x[m][shift]) << (64 - (1 << usebits))) == 0
   

6. MarcoFalke added the label P2P on Nov 1, 2016
7. laanwj renamed this:
   net: make a few values immutible, and use deterministic randomness for the localnonce
   net: make a few values immutable, and use deterministic randomness for the localnonce
   on Nov 2, 2016
8. 
   sipa commented at 0:53 am on November 3, 2016: member

   utACK aff6584e09938768838a768b67722db553cf8ef4
9. 
   laanwj commented at 9:13 am on November 3, 2016: member

   utACK https://github.com/bitcoin/bitcoin/commit/aff6584e09938768838a768b67722db553cf8ef4, though @MarcoFalke ’s crash seems worrying.
10. 
    sipa commented at 9:23 am on November 3, 2016: member

    @MarcoFalke’s failure is a randomness test in libsecp256k1 that has a very low (but still too high) false positive rate.
11. laanwj merged this on Nov 3, 2016
12. laanwj closed this on Nov 3, 2016

    ---

13. laanwj referenced this in commit fcf61b80fa on Nov 3, 2016
14. codablock referenced this in commit 98e8c31a92 on Sep 19, 2017
15. codablock referenced this in commit dd7669bc7c on Jan 13, 2018
16. andvgal referenced this in commit 3ed2df9327 on Jan 6, 2019
17. random-zebra referenced this in commit cbd9271afb on Sep 7, 2020
18. MarcoFalke locked this on Sep 8, 2021

Contributors
theuni MarcoFalke sipa laanwj

Labels
P2P