Return the type when it's unknown instead of throwing an exception #9113

pull rebroad wants to merge 1 commits into bitcoin:master from rebroad:ReturnNotThrow changing 1 files +1 −1

rebroad commented at 10:25 AM on November 9, 2016: contributor

Alternative to #9112 ?
Return the type when it's unknown instead of throwing an exception f962a840be

in src/protocol.cpp:None in f962a840be

 174 | @@ -175,7 +175,7 @@ std::string CInv::GetCommand() const
 175 |      case MSG_FILTERED_BLOCK: return cmd.append(NetMsgType::MERKLEBLOCK);
 176 |      case MSG_CMPCT_BLOCK:    return cmd.append(NetMsgType::CMPCTBLOCK);
 177 |      default:
 178 | -        throw std::out_of_range(strprintf("CInv::GetCommand(): type=%d unknown type", type));
 179 | +        return strprintf("0x%08x", type);

paveljanik commented at 10:26 AM on November 9, 2016:

Or even unknown(0x%08x)?

paveljanik commented at 10:28 AM on November 9, 2016: contributor

I prefer this solution because it fixes the cause - throwing the exception.
fanquake added the label Docs and Output on Nov 9, 2016
laanwj commented at 9:59 AM on November 11, 2016: member

Closing in favor of #9112
laanwj closed this on Nov 11, 2016
MarcoFalke locked this on Sep 8, 2021

Contributors

Labels

Linked (view graph)

#9112 Avoid ugly exception in log on unknown inv type