One fDisconnect to rule them all #9129

pull rebroad wants to merge 1 commits into bitcoin:master from rebroad:OnefDisconnect changing 1 files +7 −7

rebroad commented at 6:38 am on November 11, 2016: contributor

Alternative to #9117 (and all the others that come after it!)…
One fDisconnect to rule them all d9a77da7fb
rebroad force-pushed on Nov 11, 2016
theuni commented at 6:48 am on November 11, 2016: member

It says right in the PR description for #9117 that it is meant to be an uncontroversial quick fix for a crash while the more complete fix is being worked on. That complete fix is included in #9128.

Dueling PR’s really aren’t helpful…
MarcoFalke commented at 9:07 am on November 11, 2016: member

Agree with @theuni: We should focus on review of #9128. This seems to refactor the code in the wrong direction, closing for now.
MarcoFalke closed this on Nov 11, 2016
MarcoFalke added the label Refactoring on Nov 11, 2016
MarcoFalke locked this on Sep 8, 2021