The png was sampled too low, so displayed incorrectly on high res displays. Also, I modified the alpha channel a bit.
[qt] Make network disabled icon 50% opaque #9145
pull MarcoFalke wants to merge 1 commits into bitcoin:master from MarcoFalke:Mf1611-qtNetworkIcon changing 7 files +15 −34-
MarcoFalke commented at 1:52 PM on November 12, 2016: member
- MarcoFalke added the label GUI on Nov 12, 2016
- MarcoFalke added this to the milestone 0.14.0 on Nov 12, 2016
-
in src/qt/res/src/network_disabled.svg:None in fa30b060ee outdated
4 | @@ -5,11 +5,11 @@ 5 | xmlns:rdf="http://www.w3.org/1999/02/22-rdf-syntax-ns#" 6 | xmlns:svg="http://www.w3.org/2000/svg" 7 | xmlns="http://www.w3.org/2000/svg" 8 | - id="svg2"
paveljanik commented at 6:46 PM on November 12, 2016:isn't this only re-sorted?
MarcoFalke commented at 8:31 PM on November 12, 2016:Inkscape did this.
luke-jr commented at 9:33 PM on November 12, 2016:So don't use Inkscape...?
MarcoFalke commented at 9:09 PM on November 13, 2016:Fixed sorting nit
in src/qt/res/src/network_disabled.svg:None in fa30b060ee outdated
9 | - viewBox="0 0 24 24" 10 | - height="24" 11 | + version="1.2" 12 | width="24" 13 | - version="1.2"> 14 | + height="24"
luke-jr commented at 9:33 PM on November 12, 2016:The size of the SVG isn't changed...
MarcoFalke commented at 9:09 PM on November 13, 2016:This is not required. You can tell the program of your choice what dpi to sample at.
Nonetheless, I changed it to
92for this svg, as well as for allconnect-$N.svgjonasschnelli commented at 9:15 AM on November 13, 2016: contributorutACK fa30b060eec1f51238292a63039dcc7943abf236
SVG's XML is interpreted and created differently. No need for bikeshedding there.
Victorsueca commented at 5:56 PM on November 13, 2016: noneACK fa30b06 Tested on Windows x64
[qt] Make network disabled icon 50% opaque fa42e4a082MarcoFalke force-pushed on Nov 13, 2016paveljanik commented at 7:44 AM on November 14, 2016: contributorNice and reviewable now 👍 ACK https://github.com/bitcoin/bitcoin/pull/9145/commits/fa42e4a082e409794d0a00a8bbffc35142a17d32
jonasschnelli merged this on Nov 14, 2016jonasschnelli closed this on Nov 14, 2016jonasschnelli referenced this in commit 924745dd6f on Nov 14, 2016paveljanik commented at 7:48 AM on November 14, 2016: contributorThanks to both Marco and Luke!
MarcoFalke deleted the branch on Nov 14, 2016luke-jr referenced this in commit 58e922ecd4 on Dec 21, 2016codablock referenced this in commit 2b99a4b4e8 on Jan 15, 2018codablock referenced this in commit e02f313471 on Jan 15, 2018andvgal referenced this in commit a5cf1bf64f on Jan 6, 2019andvgal referenced this in commit 7e34a27a30 on Jan 6, 2019CryptoCentric referenced this in commit f83bcb2389 on Feb 24, 2019MarcoFalke locked this on Sep 8, 2021LabelsMilestone
0.14.0
github-metadata-mirror
This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-14 18:15 UTC
This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-14 18:15 UTC
This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me
More mirrored repositories can be found on mirror.b10c.me