Removal of "free transaction" logic from codebase #9158

pull Leviathn wants to merge 2 commits into bitcoin:master from Leviathn:patch-1 changing 1 files +0 −28

Leviathn commented at 5:46 PM on November 14, 2016: none

This is the first of a series of pull requests to remove all "free transaction" logic from the codebase

Update mining.cpp

This is the first of a series of pull requests to remove all "free transaction" logic from the codebase.

8c67a8cf67

paveljanik commented at 5:50 PM on November 14, 2016: contributor

@Leviathn ? Do you think that estimatepriority was not called/referenced at all? Travis shows you, what to do next.
Leviathn commented at 5:57 PM on November 14, 2016: none

Thanks for the guidance - just getting into the swing of things..
Update mining.cpp
removal of reference
ac90ebc232
morcos commented at 6:03 PM on November 14, 2016: member

@Leviathn I removed the functionality of estimate*priority in #7730. I didn't think it was necessarily a good idea to remove the RPC call itself until it had been marked deprecated for a release. I didn't know if there were external applications relying on those API calls at least returning something.

What do others think?
sipa commented at 6:05 PM on November 14, 2016: member

When did we mark it as deprecated?
morcos commented at 6:05 PM on November 14, 2016: member

@sipa last week.

(for 0.14)
Leviathn commented at 6:08 PM on November 14, 2016: none

Not trying to step on your toes @morcos - I know fees are where you've been focusing on lately : I just saw an opportunity to contribute by removing what I see (i think obviously so) as useless functionality in a fee-saturated Bitcoin.
sipa commented at 6:12 PM on November 14, 2016: member

I think most people agree it's useless at this point, but we normally don't break RPC compatibility without deprecating it first.
morcos commented at 6:14 PM on November 14, 2016: member

@Leviathn I'm 100% in agreement that we should remove all the priority code. I was going to suggest that as a topic for discussion in this weeks IRC development meeting. Please join us. I'm not sure if its a change that we'll get in for 0.14, but would be nice to agree we can move forward with it.

The RPC calls in particular though I thought we might leave around for backwards compatibility until we'd given users enough notice.

I just looked and there are a couple of cleanups that could be done now though if you are interested. In tests, qt and wallet code there are calls to estimate*priority that are now useless. They could be removed. I'd be happy to review that PR.
Leviathn commented at 6:16 PM on November 14, 2016: none

Ok - After reviewing #7730 it appears your clean-up there is comprehensive @morcos - so, i'll close this and reopen another PR for the Tests, QT, and Wallet xcode removals. I'll be happy to join you this week re - the Dev meet.

I appreciate the quality feedback
Leviathn closed this on Nov 14, 2016
MarcoFalke locked this on Sep 8, 2021

Contributors