Globals: Pass Consensus::Params through CBlockTreeDB::LoadBlockIndexGuts() #9176

1. 
   jtimon commented at 6:45 am on November 17, 2016: contributor

   Part of #7829
2. jtimon force-pushed on Nov 17, 2016
3. in src/txdb.cpp: in 2d194fa50d outdated

   198@@ -199,8 +199,8 @@ bool CBlockTreeDB::LoadBlockIndexGuts(boost::function<CBlockIndex*(const uint256
   199                 pindexNew->nStatus        = diskindex.nStatus;
   200                 pindexNew->nTx            = diskindex.nTx;
   201 
   202-                if (!CheckProofOfWork(pindexNew->GetBlockHash(), pindexNew->nBits, Params().GetConsensus()))
   203-                    return error("LoadBlockIndex(): CheckProofOfWork failed: %s", pindexNew->ToString());
   204+                if (!CheckProofOfWork(pindexNew->GetBlockHash(), pindexNew->nBits, consensusParams))
   205+                    return error("%s: CheckProofOfWork failed: %s", __func__, pindexNew->ToString());
   

   ---

   ---

   

   mrbandrews commented at 7:23 pm on November 17, 2016:

   Nit: if you’re changing to use func, there’s another opportunity to do so a few lines below so the style is consistent.
4. 
   mrbandrews commented at 7:24 pm on November 17, 2016: contributor

   Code review ACK
5. jtimon force-pushed on Nov 18, 2016
6. 
   jtimon commented at 9:52 pm on November 18, 2016: contributor

   Updated fixing @mrbandrews ’s nit.
7. jtimon force-pushed on Dec 3, 2016
8. 
   jtimon commented at 7:25 am on December 3, 2016: contributor

   Needed rebase after renaming main.o, see #9260 (although needed, the rebase was clean in this case)
9. Globals: Pass Consensus::Params through CBlockTreeDB::LoadBlockIndexGuts() b324b28209
10. jtimon force-pushed on May 18, 2017
11. 
    jtimon commented at 8:26 pm on May 18, 2017: contributor

    Needed rebase
12. 
    laanwj commented at 8:01 am on June 25, 2017: member

    utACK b324b28
13. laanwj merged this on Jun 25, 2017
14. laanwj closed this on Jun 25, 2017

    ---

15. laanwj referenced this in commit d609fd85ca on Jun 25, 2017
16. jtimon deleted the branch on Jun 26, 2017
17. PastaPastaPasta referenced this in commit 30b6457aa1 on Jul 6, 2019
18. PastaPastaPasta referenced this in commit 3421d8e7de on Jul 8, 2019
19. PastaPastaPasta referenced this in commit 3e1b4c2760 on Jul 9, 2019
20. PastaPastaPasta referenced this in commit 8677d7599b on Jul 11, 2019
21. barrystyle referenced this in commit 31c8a01b97 on Jan 22, 2020
22. DrahtBot locked this on Sep 8, 2021

Contributors
jtimon mrbandrews laanwj