The deserialization stuff was copied from peers.dat...
Doc: Fix copypasted comment #9216
pull paveljanik wants to merge 1 commits into bitcoin:master from paveljanik:20161124_commentfix_banmap changing 1 files +1 −1-
paveljanik commented at 11:14 AM on November 24, 2016: contributor
-
Fix copypasted comment. f26da35142
- fanquake added the label Docs and Output on Nov 24, 2016
-
MarcoFalke commented at 12:21 PM on November 24, 2016: member
I remember some rule that comments should not describe what the code does, but rather why the code does (some weird) stuff.
I don't think (de)serialization is weird, so you might as well remove those altogether?
-
paveljanik commented at 12:25 PM on November 24, 2016: contributor
@MarcoFalke I do not have problem with that. Will wait for other comments.
-
jonasschnelli commented at 12:42 PM on November 24, 2016: contributor
ACK f26da35142c1d8869cb171d3053aaf2ec3f6cca1. I'm all in for better comments (can be a different PR).
-
paveljanik commented at 12:49 PM on November 24, 2016: contributor
Yes, in this case, it documents the contents of the file being read.
-
MarcoFalke commented at 1:00 PM on November 24, 2016: member
Fine, just going to merge this.
- MarcoFalke merged this on Nov 24, 2016
- MarcoFalke closed this on Nov 24, 2016
- MarcoFalke referenced this in commit bc121b0eb1 on Nov 24, 2016
- codablock referenced this in commit fa08100c62 on Jan 16, 2018
- codablock referenced this in commit 7d2d3a6c90 on Jan 16, 2018
- codablock referenced this in commit d5f2f07961 on Jan 17, 2018
- andvgal referenced this in commit 3287a98922 on Jan 6, 2019
- CryptoCentric referenced this in commit 02bc70bbce on Feb 25, 2019
- random-zebra referenced this in commit 116bb50765 on Apr 20, 2021
- MarcoFalke locked this on Sep 8, 2021
Contributors
Labels