v0.13.1.
I've been trying to figure out how RBF works and at first, I couldn't find the settings in the docs.
Once I gathered these from the source, I couldn't get it to work (still get that txn-mempool-conflict (code -26)).
Because I can't get this to work, I can't create a doco PR myself, but I'd like to see the following documented:
IIRC nothing needs to be added to the bitcoin.conf file as opt-in RBF should already be enabled by default.
To send a transaction that signals opt-in RBF, at least one input's sequence number must be less than MAX_INT.
@unsystemizer Can you provide exact step to reproduce the txn-mempool-conflict? Also, you might want to enable the option added in #8601 to opt-in with the wallet.
Yes I can, but that's not really why I've created this issue. What I want is that once the docs or manpages are improved, noone who RTFM will end up asking what settings have to be enabled for this to work. Put another way, IMO https://github.com/bitcoin/bitcoin/search?utf8=%E2%9C%93&q=walletrbf should contain at least one Markdown or text result, but there are none. One shouldn't need to go thru C++ code to figure this out.
Now, to answer your question: I enabled walletrbf as well as the other one which you didn't mention (mempoolreplacement) and restarted. First I created 2 "same" send tx from the same address, one with a 0 miner fee, one with a non-0 miner fee (216 bytes, 0.00015 BTC, on testnet) and then I sent them in that order using debug console. The 2nd one failed with the above mentioned error. But again, I am not looking for help on how to make this work, but for the settings to be documented somewhere (https://github.com/bitcoin/bitcoin/tree/master/doc/man or wherever appropriate). Once it's documented, I'll read the docs and make it work.
@achow101- https://github.com/bitcoin/bitcoin/blob/0.13/doc/release-notes/release-notes-0.12.0.md says mempoolreplacement=0, implying by default it is off. I know this is for v0.12, but I didn't find any updates regarding this in a later version, so unless 0 means yes here, something needs to be changed/enabled for RBF to work.... I have mempoolreplacement=1.
@unsystemizer the release notes say
Transaction replacement can be disabled with a new command line option, '-mempoolreplacement=0'.
That implies that transaction replacement is already enabled by default and command to disable is the given onee.
Okay. I tried without mempoolreplacement in the config file as well, also got the same error. So likely my transactions weren't correct.
To send a transaction that signals opt-in RBF, at least one input's sequence number must be less than MAX_INT.
My input sequence number is identical in the both transactions. Is there an explorer example or a unit test that we can reference?
Back to this topic of docs: I just did bitcoind -help one more time and had another look, and there's no mempoolreplacement or walletrdf in the output. Do you agree that these options should be documented as other defaults are?
My input sequence number is identical in the both transactions. Is there an example or a unit test of for this that we can reference?
BIP 125: https://github.com/bitcoin/bips/blob/master/bip-0125.mediawiki documents what needs to be done.
RBF tests are available at https://github.com/bitcoin/bitcoin/blob/master/qa/rpc-tests/replace-by-fee.py
Back to this topic of docs: I just did bitcoind -help one more time and had another look, and there's no mempoolreplacement or walletrdf in the output. Do you agree that these options should be documented as other defaults are?
Look more closely, under Node relay options. Here it is in the code: https://github.com/bitcoin/bitcoin/blob/master/src/init.cpp#L468
It would probably be a good idea to document all default node policy behavior. I will write those.
mempoolreplacement only controls node acceptance of BIP-125 RBF transactions, it has no influence on the wallet.
walletrbf causes the wallet to set the flag, but is not supported by any released version of Bitcoin Core. (it is, however, supported by Bitcoin Knots since v0.12.0)
v0.13.1.
According to 37ac67816afbefe88806e0325b8d3719c411183e this option was added in 0.14.0