qt: layoutAboutToChange signal is called layoutAboutToBeChanged #9255

1. 
   laanwj commented at 10:45 AM on December 1, 2016: member

   This was misnamed, resulting in a warning message and missing functionality. I'm not sure what the change in behavior will be here, this needs testing.

   Also remove connection to non-existing slot "test". This was used for testing if the signal arrived. It is no longer necessary.

   Fixes:

   2016-12-01 10:04:06 GUI: QObject::connect: No such signal PeerTableModel::layoutAboutToChange() in qt/rpcconsole.cpp:518
   2016-12-01 10:04:06 GUI: QObject::connect:  (receiver name: 'RPCConsole')
   2016-12-01 10:04:06 GUI: QObject::connect: No such slot RPCConsole::test() in qt/rpcconsole.cpp:781
   2016-12-01 10:04:06 GUI: QObject::connect:  (receiver name: 'RPCConsole')

2. qt: layoutAboutToChange signal is called layoutAboutToBeChanged

   This was misnamed, resulting in a warning message and missing
   functionality. I'm not sure what the change in behavior will be here,
   this needs testing.
   
   Also remove connection to non-existing slot "test".
   This was used for testing if the signal arrived. It is no
   longer necessary.
   
   Fixes:
   
       2016-12-01 10:04:06 GUI: QObject::connect: No such signal PeerTableModel::layoutAboutToChange() in qt/rpcconsole.cpp:518
       2016-12-01 10:04:06 GUI: QObject::connect:  (receiver name: 'RPCConsole')
       2016-12-01 10:04:06 GUI: QObject::connect: No such slot RPCConsole::test() in qt/rpcconsole.cpp:781
       2016-12-01 10:04:06 GUI: QObject::connect:  (receiver name: 'RPCConsole')

   297cc20e70
3. laanwj added the label GUI on Dec 1, 2016
4. 
   achow101 commented at 1:19 PM on December 1, 2016: member

   This change should only affect the multselection of peers for banning.

5. 
   MarcoFalke commented at 8:19 PM on December 2, 2016: member

   git grep - ACK 297cc20e70dff6565bde13fc5386327b312333df

6. qt: Remove on_toggleNetworkActiveButton_clicked from RPCConsole

   There is no network toggle button (anymore?) in the RPC console.
   Removes another warning (#9250).

   f36349e898
7. 
   laanwj commented at 4:56 AM on December 7, 2016: member

   Added #9250

8. MarcoFalke added this to the milestone 0.14.0 on Dec 7, 2016
9. laanwj merged this on Dec 8, 2016
10. laanwj closed this on Dec 8, 2016

    ---

11. laanwj referenced this in commit 9851a8461d on Dec 8, 2016
12. luke-jr referenced this in commit 642641ca69 on Dec 21, 2016
13. codablock referenced this in commit c2b83d21b9 on Sep 9, 2017
14. codablock referenced this in commit 8b3699dcc2 on Sep 11, 2017
15. UdjinM6 referenced this in commit 91d99fcd3f on Sep 11, 2017
16. MarcoFalke locked this on Sep 8, 2021

Milestone
0.14.0