Fix more CWallet/CWalletDB layer violations #9256

pull jonasschnelli wants to merge 4 commits into bitcoin:master from jonasschnelli:2016/12/ref_walletdb changing 8 files +393 −337
  1. jonasschnelli commented at 12:16 PM on December 1, 2016: contributor

    This is another wallet/walletdb refactoring a.k.a. layer violation cleanup.

    This is a stepping stone for...

    • wallet manipulation tool (compile walletdb without main, etc.) (something like #8745)
    • wallet database abstraction (use a different wallet backend [liblogdb, sqlite] in parallel to bdb) (something like #5686)

    Together with #9143, this makes CWalletDB independent from CWallet (main goal of the current refactoring).

    What is does...

    • Removes the CDB::Verify callback (can be executed independently)
    • CWalletDB::LoadWallet and CWalletDB::Recover will map and/or check for records over a callback thus allow a flexible layer setup.
  2. [MOVEONLY] move ReadKeyValue to walletmapper.c 70bbb9354c
  3. [MOVEONLY] move CWalletScanState to walletdb.h (expose it) 860e775ac3
  4. Remove recover callback from CDB aa80bdec8d
  5. jonasschnelli added the label Refactoring on Dec 1, 2016
  6. jonasschnelli added the label Wallet on Dec 1, 2016
  7. jonasschnelli commented at 12:16 PM on December 1, 2016: contributor

    First two commits are (sort of) moveonly.

    It makes most sense to review https://github.com/bitcoin/bitcoin/pull/9256/commits/8fea0a065c1d45637e2015c6fdeb2a4665c34864

  8. Avoid CWallet usage in CWalletDB 448a0233b5
  9. jonasschnelli force-pushed on Dec 1, 2016
  10. MarcoFalke commented at 3:45 PM on December 2, 2016: member

    Fails with the following when setting up the rpc network

    Error: Cannot downgrade wallet
    
      File "/home/travis/build/bitcoin/bitcoin/qa/rpc-tests/test_framework/test_framework.py", line 144, in main
        self.setup_network()
      File "/home/travis/build/bitcoin/bitcoin/build/../qa/rpc-tests/p2p-compactblocks.py", line 127, in setup_network
        ["-debug", "-logtimemicros", "-txindex"]])
    
  11. jonasschnelli commented at 9:58 AM on March 6, 2017: contributor

    Closing for now... maybe someone pick's that up later.

  12. jonasschnelli closed this on Mar 6, 2017

  13. MarcoFalke locked this on Sep 8, 2021

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-21 15:15 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me