There’s two types of flags: consensus and script #9271

1. 
   jtimon commented at 5:47 am on December 3, 2016: contributor

   Replaces #7779 Unlike the previous, this distinguishes between consensus flags and the subset of them that are only related to script. We can decouple them from each other.

   There’s extra exploration in https://github.com/jtimon/bitcoin/commits/0.13-consensus-flags Things to explore:

   • Calling GetConsensusFlags from ContextualCheckBlock or “upwards” should look bad in benchmarks (although maybe not so much since bip9 is cached and ISM has been eliminated), but would complete GetConsensusFlags().

   • Moving GetConsensusFlags “upwards” can reduce the impact of unifying logic from both ConnectBlock and ContextualCheckBlock in GetConsensusFlags.

2. jtimon force-pushed on Dec 3, 2016
3. fanquake added the label Consensus on Dec 3, 2016
4. jtimon closed this on Dec 3, 2016

   ---

5. jtimon reopened this on Dec 3, 2016

   ---

6. jtimon force-pushed on Dec 3, 2016
7. jtimon force-pushed on Dec 3, 2016
8. reinier19 approved
9. reinier19 approved
10. 
    reinier19 commented at 3:37 am on December 4, 2016: none

    good
11. 
    reinier1991 commented at 3:40 am on December 4, 2016: none

    hajs
12. reinier1991 approved
13. jtimon force-pushed on Dec 5, 2016
14. jtimon force-pushed on Dec 5, 2016
15. jtimon force-pushed on Dec 5, 2016
16. jtimon renamed this:
    Discusion : 0.13 consensus flags error
    Discussion: There's two types of flags: consensus and script
    on Dec 5, 2016
17. 
    jtimon commented at 12:24 pm on December 5, 2016: contributor

    Updated code and description.

    EDIT: sorry! still failing tests for a supposedly simple POC!

    Also sorry for maybe making more commits than necessary, squash suggestions very wecomed, specially if they contain suggestions about the new commit message.

18. jtimon force-pushed on Dec 16, 2016
19. jtimon force-pushed on Dec 16, 2016
20. jtimon force-pushed on Dec 16, 2016
21. jtimon force-pushed on Dec 16, 2016
22. jtimon force-pushed on Dec 17, 2016
23. jtimon force-pushed on Dec 17, 2016
24. jtimon force-pushed on Dec 20, 2016
25. jtimon force-pushed on Dec 20, 2016
26. jtimon force-pushed on Jan 25, 2017
27. jtimon force-pushed on Apr 4, 2017
28. 
    jtimon commented at 8:01 pm on April 4, 2017: contributor

    Rebased, still don’t understand why the script_tests.cpp are failing.
29. jtimon renamed this:
    Discussion: There's two types of flags: consensus and script
    There's two types of flags: consensus and script
    on Apr 5, 2017
30. jtimon force-pushed on May 19, 2017
31. 
    jtimon commented at 2:37 am on May 19, 2017: contributor

    Needed rebase, rebased on top of #10427
32. jtimon force-pushed on Jun 14, 2017
33. 
    jtimon commented at 6:22 am on June 14, 2017: contributor

    Needed rebase, even though the first commit of #10192 hasn’t been merged yet (that will need rebase too).
34. MOVEONLY: Separate consensus/flags.h from script/bitcoinconsensus.h...

    ...to make sure only consensus flags as an interface to bitcoinconsensus
    
    TODO: Decouple the bits in consensus flags from the ones in the interpreter flags

    e11ba29ecb
35. Introduce ScriptFlagsFromConsensus and use it in bitcoinconsensus_verify_script 5d1961b761
36. QA: script_tests.cpp: Decouple consensus flags from scripts'

    this also helps test ScriptFlagsFromConsensus

    7efadd4c86
37. Consensus: Introduce GetConsensusFlags() bips: 16, 65, 66, 112, 141

    - Replacing GetBlockScriptFlags
    - Use GetConsensusFlags and ScriptFlagsFromConsensus from ConnectBlock
      and LimitMempoolSize

    8028219b8f
38. Move to GetConsensusFlags: bips: 68, 112 (note 68 is not script) 6c92a2c9fc
39. Introduce bitcoinconsensus_TX_VERIFY_BIP30 flag

    ...and use it from GetConsensusFlags()
    
    Nothing can be deployed the block after genesis
    
    (ie BIP30: Don't look for ancestors of the genesis block)

    c5bfe63902
40. Call GetConsensusFlags before ContextualCheckBlock for BIPs: 34, 113, 141 9d86f684e7
41. ERROR-unit: Make sure consensus and script flags keep decoupled from each other 7db1cb4135
42. UNDO: fix ERROR-unit 994551a4f9
43. Extra: Improve GetConsensusFlags 6bd6a578e2
44. jtimon force-pushed on Jul 4, 2017
45. 
    jtimon commented at 6:20 pm on July 4, 2017: contributor

    Needed rebase after #10192. I still don’t understand why the tests commented in https://github.com/bitcoin/bitcoin/pull/9271/commits/994551a4f9c8f269c291c12296409a81f64840e9 are failing.
46. 
    jtimon commented at 9:48 pm on August 24, 2017: contributor

    Closing for now
47. jtimon closed this on Aug 24, 2017

    ---

48. DrahtBot locked this on Sep 8, 2021

Contributors
jtimon reinier19 reinier1991

Labels
Consensus