Some minor testing cleanups #9276

1. 
   morcos commented at 8:53 pm on December 4, 2016: member

   • first commit just roughly orders all of the RPC tests for running time and puts in comments so new tests can be added at approximately the right place. i’m not sure its worth doing this very often.

   • second commit removes setting of relaypriority=0 from the rpc tests. it obviously wasn’t necessary if they were passing after the -limitfreerelay change to default to 0.

   • third commit removes the obsolete file run-bitcoind-for-test.sh, but someone should check if I did this correctly, since now that I’ve removed it from .gitignore, everyones repos will complain that they have an extra file sitting around. i wasn’t sure how to clean that up?

   let me know if only some of these commits are wanted and i get rid of the unwanted ones.

2. Reorder RPC tests for running time e2184ccc1d
3. remove relaypriority from rpc tests 2a99522bbf
4. remove obsolete run-bitcoind-for-test.sh 30b620c48a
5. fanquake added the label Tests on Dec 4, 2016
6. 
   MarcoFalke commented at 11:53 pm on December 4, 2016: member

   utACK. I think you can also remove .bitcoin from the gitignore file.

   Edit: 3rd commit is a follow up of #8504

7. 
   laanwj commented at 10:01 am on December 5, 2016: member

   Another minor idea would be to remove explicit -server from the bitcoind command lines. That will catch a problem with the option (e.g. as in #9010) next time.
8. 
   MarcoFalke commented at 10:24 am on December 5, 2016: member

   My guess would be that the gui binary can no longer be used for running the tests after removal of -server?
9. 
   MarcoFalke commented at 11:13 am on December 6, 2016: member

   third commit removes the obsolete file run-bitcoind-for-test.sh, but someone should check if I did this correctly, since now that I’ve removed it from .gitignore, everyones repos will complain that they have an extra file sitting around. i wasn’t sure how to clean that up?

   Everyone who cares about a “clean” work dir can delete the file by themself. It will still be generated every time you switch back to a old enough commit, so one could argue to leave the .gitignore patch out of this pull and submit it some time later, but I don’t think this is worth it.

10. 
    laanwj commented at 12:22 pm on December 6, 2016: member

    My guess would be that the gui binary can no longer be used for running the tests after removal of -server?

    Hm good point. So that’s why it’s being passed? okay

11. 
    laanwj commented at 6:47 am on December 8, 2016: member

    since now that I’ve removed it from .gitignore, everyones repos will complain that they have an extra file sitting around. i wasn’t sure how to clean that up?

    I don’t think see that as a problem. At least it will make it obvious that there’s a redundant file around and that they can delete it. Unlike when you keep it in gitignore.

    utACK 30b620c

12. laanwj merged this on Dec 8, 2016
13. laanwj closed this on Dec 8, 2016

    ---

14. laanwj referenced this in commit ea33f197ef on Dec 8, 2016
15. 
    laanwj commented at 7:01 am on December 8, 2016: member

    If you get a config.status: error: cannot find input file: qa/pull-tester/run-bitcoind-for-test.sh.in` message in configure after pulling this, re-run autogen.sh
16. codablock referenced this in commit 8e54dca361 on Jan 16, 2018
17. codablock referenced this in commit 90dba92656 on Jan 16, 2018
18. codablock referenced this in commit 7322489ca2 on Jan 17, 2018
19. andvgal referenced this in commit a92f65c53f on Jan 6, 2019
20. CryptoCentric referenced this in commit 9caf30b519 on Feb 25, 2019
21. zkbot referenced this in commit 025bd44543 on Nov 21, 2020
22. zkbot referenced this in commit 7a0a268054 on Dec 2, 2020
23. zkbot referenced this in commit c8896f9907 on Dec 2, 2020
24. MarcoFalke locked this on Sep 8, 2021

Contributors
morcos MarcoFalke laanwj

Labels
Tests