CMutableTransaction is defined as struct #9282

pull paveljanik wants to merge 1 commits into bitcoin:master from paveljanik:20161205_CMutableTransaction_is_struct changing 1 files +1 −1
  1. paveljanik commented at 10:15 AM on December 5, 2016: contributor

    This removes few warnings coming from #8580:

    In file included from test/script_P2SH_tests.cpp:7:
    In file included from ./keystore.h:12:
    In file included from ./script/standard.h:9:
    In file included from ./script/interpreter.h:10:
    ./primitives/transaction.h:270:1: warning: struct 'CMutableTransaction' was previously declared as a class [-Wmismatched-tags]
    struct CMutableTransaction;
    ^
    ./core_io.h:14:7: note: previous use is here
    class CMutableTransaction;
          ^
    In file included from test/script_P2SH_tests.cpp:7:
    In file included from ./keystore.h:12:
    In file included from ./script/standard.h:9:
    In file included from ./script/interpreter.h:10:
    ./primitives/transaction.h:457:1: warning: 'CMutableTransaction' defined as a struct here but previously declared as a class [-Wmismatched-tags]
    struct CMutableTransaction
    ^
    ./core_io.h:14:1: note: did you mean struct here?
    class CMutableTransaction;
    ^~~~~
    struct
    2 warnings generated.
    

    Definition is here https://github.com/bitcoin/bitcoin/blob/master/src/primitives/transaction.h#L457

  2. CMutableTransaction is defined as struct. c4b6fa8edf
  3. laanwj commented at 11:54 AM on December 5, 2016: member

    Thanks, this fixes a warning in almost every compilation unit

  4. laanwj merged this on Dec 5, 2016
  5. laanwj closed this on Dec 5, 2016

  6. laanwj referenced this in commit 7d5d44969b on Dec 5, 2016
  7. codablock referenced this in commit 8090152bf4 on Jan 16, 2018
  8. codablock referenced this in commit 4f71e29d64 on Jan 16, 2018
  9. codablock referenced this in commit 7d887dafb1 on Jan 17, 2018
  10. andvgal referenced this in commit 02cc419ade on Jan 6, 2019
  11. CryptoCentric referenced this in commit 53570a3f4b on Feb 25, 2019
  12. CryptoCentric referenced this in commit 7a8bdbb963 on Feb 26, 2019
  13. DrahtBot locked this on Sep 8, 2021

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-28 00:15 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me