This is another violation of the one definition rule (like #9269), as the type for mapOrphanTransactionsByPrev did not match the one in net_processing.cpp anymore. As it now depends on a custom comparator (IteratorComparator, defined in net_processing.cpp as well), it seems too much hassle to correctly expose it to the tests. Instead, this PR just removes the one test it was referenced in.
Remove mapOrphanTransactionsByPrev from DoS_tests #9291
pull sipa wants to merge 1 commits into bitcoin:master from sipa:reallyoneorphan changing 1 files +0 −2-
sipa commented at 7:08 AM on December 6, 2016: member
-
819ca3f18e
Remove mapOrphanTransactionsByPrev from DoS_tests
This is another violation of the one definition rule, as the type for mapOrphanTransactionsByPrev did not match the one in net_processing.cpp anymore. As it now depends on a custom Iterator, it seems too much hassle to correctly expose it to the tests. Instead, this commit just removes the one test it was referenced in.
-
paveljanik commented at 7:22 AM on December 6, 2016: contributor
ACK 819ca3f
- MarcoFalke added the label Tests on Dec 6, 2016
-
laanwj commented at 7:37 AM on December 8, 2016: member
At some point we may want to add "private interface" header for cases like this, for types and other internals that need to be inspected by the (whitebox) tests but should be opaque otherwise. But it is not worth it for this. utACK 819ca3f
- laanwj merged this on Dec 8, 2016
- laanwj closed this on Dec 8, 2016
- laanwj referenced this in commit 86017842d6 on Dec 8, 2016
- codablock referenced this in commit 9c9cbc4ed8 on Jan 16, 2018
- codablock referenced this in commit 3be1cb9f07 on Jan 16, 2018
- codablock referenced this in commit b0c0046ef0 on Jan 17, 2018
- andvgal referenced this in commit d40f38c669 on Jan 6, 2019
- CryptoCentric referenced this in commit a88006d274 on Feb 25, 2019
- MarcoFalke locked this on Sep 8, 2021
Contributors
Labels