Various RPC help outputs updated #9297

Mirobit commented at 11:25 PM on December 6, 2016: contributor

Typos, formatting and missing fields.

fanquake added the label RPC/REST/ZMQ on Dec 6, 2016

Mirobit force-pushed on Dec 6, 2016

Mirobit force-pushed on Dec 7, 2016

MarcoFalke added the label Docs and Output on Dec 7, 2016

MarcoFalke commented at 7:42 AM on December 7, 2016: member

Concept ACK 34645c1

jonasschnelli approved

jonasschnelli commented at 7:10 PM on December 8, 2016: contributor

utACK

laanwj commented at 9:13 AM on December 14, 2016: member

Would prefer to postpone this to after named arguments (#8811). That should go in soon, and also updates many RPC help texts.

Mirobit force-pushed on Jan 11, 2017

Mirobit commented at 1:33 PM on January 11, 2017: contributor

Rebased, 5754e0341b7c033d4caf99534aca47e9981bd7ed

in src/wallet/rpcwallet.cpp:None in a018674c05 outdated

 447 | @@ -448,7 +448,7 @@ UniValue listaddressgroupings(const JSONRPCRequest& request)
 448 |              "    [\n"
 449 |              "      \"address\",     (string) The bitcoin address\n"

jnewbery commented at 2:56 PM on January 11, 2017:

nit: may as well align (string) with the line below as part of this commit.

in src/wallet/rpcwallet.cpp:None in a018674c05 outdated

1268 | @@ -1269,6 +1269,10 @@ UniValue listreceivedbyaddress(const JSONRPCRequest& request)
1269 |              "    \"amount\" : x.xxx,                  (numeric) The total amount in " + CURRENCY_UNIT + " received by the address\n"
1270 |              "    \"confirmations\" : n,               (numeric) The number of confirmations of the most recent transaction included\n"
1271 |              "    \"label\" : \"label\"                (string) A comment for the address/transaction, if any\n"

jnewbery commented at 2:57 PM on January 11, 2017:

nit: should have a comma after label now that it's no longer the final element in the returned object.

in src/wallet/rpcwallet.cpp:None in a018674c05 outdated

1661 | @@ -1657,6 +1662,9 @@ UniValue listsinceblock(const JSONRPCRequest& request)
1662 |              "    \"txid\": \"transactionid\",  (string) The transaction id. Available for 'send' and 'receive' category of transactions.\n"
1663 |              "    \"time\": xxx,              (numeric) The transaction time in seconds since epoch (Jan 1 1970 GMT).\n"
1664 |              "    \"timereceived\": xxx,      (numeric) The time received in seconds since epoch (Jan 1 1970 GMT). Available for 'send' and 'receive' category of transactions.\n"
1665 | +            "    \"bip125-replaceable\": \"yes|no|unknown\",  (string) Whether this transaction could be replaced due to BIP125 (replace-by-fee);\n"
1666 | +            "                                                   may be unknown for unconfirmed transactions not in the mempool\n"
1667 | +            "    \"abandoned\": xxx          (bool) 'true' if the transaction has been abandoned (inputs are respendable). Only available for the 'send' category of transactions.\n"

jnewbery commented at 3:12 PM on January 11, 2017:

should have a comma since this isn't the final element in the returned object.

Mirobit commented at 4:21 PM on January 11, 2017:

@jnewbery Thanks, fixed all nits.

jnewbery commented at 3:16 PM on January 11, 2017: member

A few minor nits.

Mirobit force-pushed on Jan 11, 2017

jnewbery commented at 4:40 PM on January 11, 2017: member

utACK

in src/rpc/blockchain.cpp:None in cd57d563f4 outdated

 335 | @@ -336,8 +336,8 @@ std::string EntryDescriptionString()
 336 |             "    \"modifiedfee\" : n,      (numeric) transaction fee with fee deltas used for mining priority\n"
 337 |             "    \"time\" : n,             (numeric) local time transaction entered pool in seconds since 1 Jan 1970 GMT\n"
 338 |             "    \"height\" : n,           (numeric) block height when transaction entered pool\n"
 339 | -           "    \"startingpriority\" : n, (numeric) priority when transaction entered pool\n"
 340 | -           "    \"currentpriority\" : n,  (numeric) transaction priority now\n"
 341 | +           "    \"startingpriority\" : n, (numeric) DEPRECATED. priority when transaction entered pool\n"

paveljanik commented at 5:25 PM on January 11, 2017:

Small letters p and t (on the next line) look strange.

Mirobit commented at 9:06 PM on January 11, 2017:

You are right, fixed it. Thanks.

paveljanik commented at 5:26 PM on January 11, 2017: contributor

Concept ACK

RPC help updated 54ee3fcb8f

Mirobit force-pushed on Jan 11, 2017

MarcoFalke commented at 9:51 PM on January 11, 2017: member

utACK 54ee3fc

MarcoFalke merged this on Jan 12, 2017

MarcoFalke closed this on Jan 12, 2017

MarcoFalke referenced this in commit 0b738075bd on Jan 12, 2017

codablock referenced this in commit 3014b7b538 on Jan 19, 2018

codablock referenced this in commit 2bb12aaadf on Jan 20, 2018

codablock referenced this in commit a0438d5347 on Jan 21, 2018

andvgal referenced this in commit 1d12d2f6fd on Jan 6, 2019

CryptoCentric referenced this in commit dc36045259 on Feb 27, 2019

CryptoCentric referenced this in commit e11d1ae195 on Feb 27, 2019

MarcoFalke locked this on Sep 8, 2021