Refactor: Removed begin/end_ptr functions. #9305

pull kallewoof wants to merge 1 commits into bitcoin:master from kallewoof:remove-begin-end_ptr-usage changing 11 files +32 −61

kallewoof commented at 4:22 AM on December 9, 2016: member
serialize.h has a number of functions for accessing the data inside std::vectors, prepended with a warning to not use them in new code, as "with C++11 the language has built-in functionality for this and it's more readable to just use that". This PR removes these functions and their uses.
- begin_ptr(X) → X.data()
- end_ptr(X) → (X.data() + X.size())
Refactor: Removed begin/end_ptr functions. 8c1dbc5e9d
sipa commented at 4:23 AM on December 9, 2016: member

Concept ACK
fanquake added the label Refactoring on Dec 9, 2016
dcousens approved
dcousens commented at 5:26 AM on December 9, 2016: contributor

yay, utACK / concept ACK
paveljanik commented at 7:05 AM on December 9, 2016: contributor

ACK 8c1dbc5
jonasschnelli approved
jonasschnelli commented at 7:37 AM on December 9, 2016: contributor

utACK 8c1dbc5e9ddbafb77e60e8c4e6eb275a3a76ac12
laanwj commented at 12:44 PM on December 9, 2016: member

I was about to mention the developer notes, but they're already gone from there.

utACK https://github.com/bitcoin/bitcoin/pull/9305/commits/8c1dbc5e9ddbafb77e60e8c4e6eb275a3a76ac12
laanwj merged this on Dec 13, 2016
laanwj closed this on Dec 13, 2016
laanwj referenced this in commit 5233aefa3f on Dec 13, 2016
kallewoof deleted the branch on Dec 13, 2016
codablock referenced this in commit 6d6d0e34d7 on Jan 16, 2018
codablock referenced this in commit 22d279d0d7 on Jan 16, 2018
codablock referenced this in commit 0982d6d3c8 on Jan 17, 2018
andvgal referenced this in commit 25ea905b9b on Jan 6, 2019
CryptoCentric referenced this in commit c253c3701d on Feb 25, 2019
furszy referenced this in commit a87f8595fc on Apr 8, 2021
MarcoFalke locked this on Sep 8, 2021

Contributors

Labels