requesting block when cmpctblock could be requested #9318

issue rebroad opened this issue on December 11, 2016
  1. rebroad commented at 3:26 AM on December 11, 2016: contributor

    Currently the logic is such that if there is already a block (or compact block) in flight, and another block is announced, it will request a full block rather than a compact block. Example debug.log:-

    2016-12-11 03:22:21.176293 recv new best header 000000000000000000d090b379d076118bbb4f670777faef98106fc911239a51 (442881) age=46s peer=15
    2016-12-11 03:22:21.176420 send getdata cmpctblock 000000000000000000d090b379d076118bbb4f670777faef98106fc911239a51 (442881) peer=15
    2016-12-11 03:22:21.176477 send sendcmpct (announce) ver=1 peer=15
    2016-12-11 03:22:21.177076 recv new best header 00000000000000000038f3546709d33649f48339a54fe67c55cc4e568704d7d7 (442882) age=7s peer=15
    2016-12-11 03:22:21.177210 send getdata block 00000000000000000038f3546709d33649f48339a54fe67c55cc4e568704d7d7 (442882) peer=15
    

    In this example, the 2nd announced block could also have been requested as a compact block.

  2. fanquake added the label P2P on Dec 11, 2016
  3. rebroad referenced this in commit f83449c2c0 on Dec 14, 2016
  4. rebroad referenced this in commit a461dd469d on Dec 16, 2016
  5. rebroad referenced this in commit 9a6f2c967d on Dec 18, 2016
  6. rebroad referenced this in commit 985cd8ac7d on Dec 20, 2016
  7. rebroad referenced this in commit 237dfc0e87 on Dec 23, 2016
  8. rebroad referenced this in commit ecc985b04a on Dec 23, 2016
  9. rebroad referenced this in commit 6b37522d85 on Dec 24, 2016
  10. rebroad referenced this in commit 0d350d9194 on Dec 26, 2016
  11. rebroad referenced this in commit 1aed7edd82 on Dec 26, 2016
  12. rebroad referenced this in commit 5d1a0cc334 on Dec 26, 2016
  13. rebroad referenced this in commit 0a73b6b643 on Dec 26, 2016
  14. rebroad referenced this in commit d2f6ecb00e on Dec 27, 2016
  15. rebroad referenced this in commit df7b79dc83 on Dec 27, 2016
  16. MarcoFalke commented at 12:57 PM on May 9, 2020: member

    Is this still an issue with a recent version of Bitcoin Core? If yes, what are the steps to reproduce?

  17. MarcoFalke closed this on May 9, 2020

  18. DrahtBot locked this on Feb 15, 2022
Contributors
Labels

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-22 18:15 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me