[wip] Stripe downloads to reduce stallers occuring #9338

pull rebroad wants to merge 3 commits into bitcoin:master from rebroad:ReduceStalling changing 1 files +39 −28
  1. rebroad commented at 4:40 AM on December 13, 2016: contributor

    Mitigates #9213

    This may also help reduce the unresponsiveness of peers during IBD as often they encounter a big chunk of contiguous blocks that need to be added to the chain due to the current contiguous way they are downloaded.

  2. rebroad commented at 4:49 AM on December 13, 2016: contributor

    This is WIP... also need to make it so that it doesn't download the inbetween blocks from the same peer before a new peer has a chance.

  3. paveljanik commented at 6:47 AM on December 13, 2016: contributor

    Can you work on your own project and submit PR once ready?

    I do not know how it looks like for others, but for me, it is a bit more than I can absorb.

  4. Fix indentation and flow fe0401e66a
  5. Disable direct-fetch (in order to go via striping logic) 9416039ce9
  6. rebroad force-pushed on Dec 13, 2016
  7. rebroad commented at 9:16 AM on December 13, 2016: contributor

    @paveljanik It's ready for testing now. I am currently doing further testing, and will post results shortly. It was ready when I raised the PR, but is more ready now. I didn't raise the PR prematurely as the functionality was still an improvement over what was already there.

  8. Stripe downloads to reduce stallers occuring
    Mitigates #9213
    
    This may also help reduce the unresponsiveness of peers during IBD as
    often they encounter a big chunk of contiguous blocks that need to be
    added to the chain due to the current contiguous way they are
    downloaded.
    5a80993a1e
  9. fanquake added the label P2P on Dec 13, 2016
  10. rebroad commented at 9:28 AM on December 13, 2016: contributor

    @paveljanik I'd like to have a conversation with you to better understand what you are meaning regarding absorption, but here is probably not the place - where might be? Telegram perhaps? https://telegram.me/rebroad

    Ok, on 2nd thoughts I might have been overly enthusiastic raising this PR, as I realise that it won't work well in some situations, e.g. when connecting to too few peers but I do think that the advantage of github is the collaboration, and therefore it can be more efficient to advertise work in progress as several heads can sometimes find solutions sooner than one. At least, this is how I understand the process working.

    Anyway, from some perspectives I may have jumped the gun. Should I close this until it's more developed then?

  11. rebroad force-pushed on Dec 13, 2016
  12. MarcoFalke renamed this:
    Stripe downloads to reduce stallers occuring
    [wip] Stripe downloads to reduce stallers occuring
    on Dec 13, 2016
  13. rebroad commented at 12:17 PM on December 13, 2016: contributor

    There's a fault in the logic here, which I have fixed and am testing and will push once tested.

  14. rebroad commented at 4:08 AM on December 15, 2016: contributor

    not ready - needs bandwidth per node measuring before it provides real benefits.

  15. rebroad closed this on Dec 15, 2016

  16. DrahtBot locked this on Sep 8, 2021

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-22 18:15 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me