[Trivial] Adding label for amount inside of tx_valid/tx_invalid.json #9350

pull Christewart wants to merge 1 commits into bitcoin:master from Christewart:master changing 2 files +2 −2

Christewart commented at 6:36 PM on December 14, 2016: member

No description provided.
fanquake added the label Tests on Dec 15, 2016
in src/test/data/tx_invalid.json:None in 2a784b8310 outdated
```
   0 | @@ -1,7 +1,7 @@
   1 |  [
   2 |  ["The following are deserialized transactions which are invalid."],
   3 |  ["They are in the form"],
   4 | -["[[[prevout hash, prevout index, prevout scriptPubKey], [input 2], ...],"],
   5 | +["[[[prevout hash, prevout index, prevout scriptPubKey, amount], [input 2], ...],"],
```
jonasschnelli commented at 8:27 AM on December 15, 2016:

IMO the amount if optional, maybe we should use (, amount).

Christewart commented at 2:12 PM on December 15, 2016:

Yeah, I didn't know the best way to represent it as optional. We could use a ? to indicate it is optional which is what regular expressions would do :/
Adding 'amount' label to tx_valid/tx_invalid.json files 988ce2ddef
Christewart force-pushed on Dec 16, 2016
Christewart commented at 2:15 AM on December 16, 2016: member

@jonasschnelli I changed it to amount?, this is a convention that is already in https://github.com/bitcoin/bitcoin/blob/b83264d9c7a8ddb79f64bd9540caddc8632ef31f/src/test/data/script_tests.json#L2
MarcoFalke added the label Docs and Output on Jan 1, 2017
Christewart renamed this:
~~Adding label for amount inside of tx_valid/tx_invalid.json~~
[Trivial] Adding label for amount inside of tx_valid/tx_invalid.json
on Jan 13, 2017
laanwj commented at 2:00 PM on February 6, 2017: member

LGTM, utACK 988ce2d
kallewoof commented at 5:00 AM on February 9, 2017: member

utACK 988ce2d
paveljanik commented at 11:08 AM on February 9, 2017: contributor

ACK https://github.com/bitcoin/bitcoin/commit/988ce2ddef5e23da70de6ee37759a53145c6abaf
MarcoFalke merged this on Feb 27, 2017
MarcoFalke closed this on Feb 27, 2017
MarcoFalke referenced this in commit 88c2ae3ed2 on Feb 27, 2017
PastaPastaPasta referenced this in commit 536baa2cca on Dec 28, 2018
PastaPastaPasta referenced this in commit 078a95a05f on Dec 29, 2018
PastaPastaPasta referenced this in commit 32eb6aa89f on Dec 29, 2018
PastaPastaPasta referenced this in commit db7de28162 on Dec 31, 2018
PastaPastaPasta referenced this in commit 1bba9f5a9c on Jan 2, 2019
PastaPastaPasta referenced this in commit 7e7cf70fed on Jan 3, 2019
PastaPastaPasta referenced this in commit 0f1609334a on Jan 5, 2019
PastaPastaPasta referenced this in commit 6e5862ba79 on Jan 7, 2019
PastaPastaPasta referenced this in commit 8b5388d8c6 on Jan 7, 2019
PastaPastaPasta referenced this in commit 0d38c16e79 on Jan 23, 2019
PastaPastaPasta referenced this in commit 511da29bb5 on Jan 25, 2019
DrahtBot locked this on Sep 8, 2021

Contributors

Labels