wallet: Remove sendfree #9391

1. 
   MarcoFalke commented at 10:22 pm on December 20, 2016: member

   This pull is a split-off of the large patch mentioned in #6675.

   ---

   This removes the option from the wallet to not pay a fee on “small” transactions which spend “old” inputs.

   This code is no longer worth keeping around, as almost all miners prefer not to include transactions which pay no fee at all.

   ---

   Please note that it is still possible to create transaction which pay no fee at all through the raw transaction interface. Also, it is still possible to set the wallet transaction fee to any value of one satoshi or more.

2. MarcoFalke added the label Wallet on Dec 20, 2016
3. MarcoFalke added this to the milestone 0.15.0 on Dec 20, 2016
4. dcousens approved
5. 
   morcos commented at 10:37 pm on December 20, 2016: member

   Concept ACK
6. 
   luke-jr commented at 10:49 pm on December 20, 2016: member

   ACK
7. in src/wallet/wallet.cpp: in fa060b2a75 outdated

   2502@@ -2517,8 +2503,6 @@ bool CWallet::CreateTransaction(const vector<CRecipient>& vecSend, CWalletTx& wt
   2503                     return false;
   2504                 }
   2505 
   2506-                dPriority = wtxNew.tx->ComputePriority(dPriority, nBytes);
   2507-
   

   ---

   ---

   

   dcousens commented at 11:01 pm on December 20, 2016:

   While understandably unused… this probably shouldn’t be put under this commit

   ---

   

   MarcoFalke commented at 11:04 pm on December 20, 2016:

   Sure, I can squash all commits after we branch off 0.14 if you mean that.

   ---

   

   dcousens commented at 11:18 pm on December 20, 2016:

   @MarcoFalke I meant removing dead code in a commit titled as adding a warning is odd (unexpected). How you rectify that, 2 commits, rebase, squash, whatever, I don’t mind.

   ---

   

   MarcoFalke commented at 1:13 am on December 21, 2016:

   Squashed. Sorry for the confusion.
8. wallet: Remove sendfree

   This removes the option from the wallet to not pay a fee on "small"
   transactions which spend "old" inputs.
   
   This code is no longer worth keeping around, as almost all miners
   prefer not to include transactions which pay no fee at all.

   fa7ddccef7
9. MarcoFalke force-pushed on Dec 20, 2016
10. 
    MarcoFalke commented at 11:29 am on December 22, 2016: member

    Closing for now.

    This is meant for 0.15, which will land in fall 2017. No need to leave this open for months while merges are still happening for 0.14 on master.

11. MarcoFalke closed this on Dec 22, 2016

    ---

12. MarcoFalke deleted the branch on Dec 26, 2016
13. DrahtBot locked this on Sep 8, 2021

Contributors
MarcoFalke dcousens morcos luke-jr

Labels
Wallet

Milestone
0.15.0