Updated listsinceblock rpc documentation #9396

pull accraze wants to merge 1 commits into bitcoin:master from accraze:docs-listsinceblock-rpc changing 1 files +1 −0

accraze commented at 1:43 AM on December 21, 2016: contributor

This PR contains updates to the documentation for listsinceblock rpc.

fixes #8758
fanquake added the label RPC/REST/ZMQ on Dec 21, 2016
MarcoFalke added the label Docs and Output on Dec 21, 2016
updated listsinceblock rpc docs
fixes #8758
3f67972654

in src/wallet/rpcwallet.cpp:None in efba947828 outdated

1636 | @@ -1637,7 +1637,7 @@ UniValue listsinceblock(const JSONRPCRequest& request)
1637 |              "\nGet all transactions in blocks since block [blockhash], or all transactions if omitted\n"
1638 |              "\nArguments:\n"
1639 |              "1. \"blockhash\"   (string, optional) The block hash to list transactions since\n"
1640 | -            "2. target-confirmations:    (numeric, optional) The confirmations required, must be 1 or more\n"
1641 | +            "2. target-confirmations:    (numeric, optional) Return the hash of the block that has target-confirmations of confirmations, for use in a further call to listsinceblock.\n"

paveljanik commented at 7:27 AM on December 21, 2016:

This is surely wrong. It should describe the meaning of the argument. And it does so in the master.

accraze force-pushed on Dec 22, 2016
accraze commented at 8:52 PM on December 22, 2016: contributor

@paveljanik I removed the incorrect description
paveljanik commented at 9:20 PM on December 22, 2016: contributor

ACK https://github.com/bitcoin/bitcoin/pull/9396/commits/3f67972654748a2f24e4aa95b6f3df5d4574ed55
instagibbs commented at 7:41 PM on December 30, 2016: member

nit: maybe add "e.g., -5 implies 5 blocks ago", in case someone reads it as "-5 blocks ago"(5 blocks in the future?)

ACK https://github.com/bitcoin/bitcoin/pull/9396/commits/3f67972654748a2f24e4aa95b6f3df5d4574ed55
laanwj merged this on Jan 4, 2017
laanwj closed this on Jan 4, 2017
laanwj referenced this in commit d65a13b773 on Jan 4, 2017
codablock referenced this in commit a81b2750fc on Jan 18, 2018
andvgal referenced this in commit 82473e1604 on Jan 6, 2019
CryptoCentric referenced this in commit c3aebfc247 on Feb 26, 2019
MarcoFalke locked this on Sep 8, 2021

Contributors

Labels

Linked (view graph)

#8758 Fix documentations of rpc `listsinceblock`