Live rescans don't convert sent payments to payment-to-self until restart #9421

issue luke-jr opened this issue on December 25, 2016

luke-jr commented at 2:25 AM on December 25, 2016: member
1. Use vanitygen to create a key/address pair.
2. Send bitcoins to the address from your Core wallet.
3. Import the private key to the Core wallet (with rescan).
4. Observe transaction list still shows merely the send.
5. Restart the client.
6. Observe the transaction list now shows payment-to-self correctly.
Expected behaviour: The rescan should change the transaction immediately.

Not sure if this affects RPC, but it does at least the GUI.
fanquake added the label Wallet on Dec 26, 2016
aureleoules commented at 9:57 AM on July 27, 2022: member

I have reproduced the bug with the same steps (used Electrum instead of vanitygen). It doesn't seem to affect the RPC listtransactions, only the GUI.

When I close the wallet (File -> Close Wallet) and re open it (File -> Open Wallet -> [name of my wallet]), the transaction is updated with the correct type "Payment to yourself".

After the rescan, the GUI receives the event here: https://github.com/bitcoin/bitcoin/blob/master/src/qt/walletview.cpp#L268

One way to fix this would be to reload the wallet on the GUI after a rescan?
jarolrod commented at 5:14 PM on July 27, 2022: member

One way to fix this would be to reload the wallet on the GUI after a rescan?

Instead of closing and re-opening the wallet, we should handle the event, updating the UI. Appears to be an issue of just not handling the signal properly.
adamjonas removed the label Wallet on Jul 27, 2022
adamjonas added the label GUI on Jul 27, 2022
hebasto commented at 5:57 PM on July 28, 2022: member

Moved to bitcoin-core/gui#636.
hebasto closed this on Jul 28, 2022
bitcoin locked this on Jul 28, 2023

Contributors

Labels