Mark the minconf parameter to move as ignored #9474

pull sipa wants to merge 1 commits into bitcoin:master from sipa:stale_minconf_parameter changing 1 files +1 −1

sipa commented at 4:40 PM on January 4, 2017: member

This will likely be removed soon through #3816, but as long as it exists, it is confusing people.

in src/wallet/rpcwallet.cpp:None in 6b5ee9b0a0 outdated

 756 | @@ -757,7 +757,7 @@ UniValue movecmd(const JSONRPCRequest& request)
 757 |              "1. \"fromaccount\"   (string, required) The name of the account to move funds from. May be the default account using \"\".\n"
 758 |              "2. \"toaccount\"     (string, required) The name of the account to move funds to. May be the default account using \"\".\n"
 759 |              "3. amount            (numeric) Quantity of " + CURRENCY_UNIT + " to move between accounts.\n"
 760 | -            "4. minconf           (numeric, optional, default=1) Only use funds with at least this many confirmations.\n"
 761 | +            "4. minconf           (numeric, optional) Ignored. Remains for backward compatibility.\n"

MarcoFalke commented at 4:45 PM on January 4, 2017:

µnit: Might want to change the name into something meaningless as well? Like 4. num (numeric, optional)

MarcoFalke commented at 4:45 PM on January 4, 2017: member

utACK 6b5ee9b0a01cf74d4accd5fe8ee3c97005f0859f
MarcoFalke added the label Docs and Output on Jan 4, 2017
Mark the minconf parameter to move as ignored ce370c1811
sipa force-pushed on Jan 4, 2017
luke-jr commented at 7:23 PM on January 4, 2017: member

Seems like this leaves people with no obvious way to set a comment, since our param parsing doesn't treat null as omitted. :/
laanwj commented at 9:28 AM on January 5, 2017: member

Seems like this leaves people with no obvious way to set a comment, since our param parsing doesn't treat null as omitted. :/

That should change after #8811, as it also uses null to mark omitted parameters. In any case this is a documentation change only, so I don't see why that should be a blocker here. utACK ce370c1
laanwj merged this on Jan 5, 2017
laanwj closed this on Jan 5, 2017
laanwj referenced this in commit 48d7e0d5e4 on Jan 5, 2017
codablock referenced this in commit e48bc13a21 on Jan 18, 2018
andvgal referenced this in commit e666c4fd80 on Jan 6, 2019
CryptoCentric referenced this in commit a9ec31d001 on Feb 26, 2019
DrahtBot locked this on Aug 16, 2022

Contributors

Labels

Linked (view graph)

#3816 Remove bolt-on accounting system