Inspired by #9529, of which this PR is a significant expansion.
- The last-timestamp-encountered variable wasn’t being used properly. Rewrite code to properly allow for new blockchain files to be written when split by month.
- Properly set a blockchain file’s access and modify times.
- Add a “debug output” option to quiet certain output that might not always be desirable.
- Update the README.
Concept ACK.
BTW: Not necessarily in this pull, but if we're going to do active development on this script it would make sense to add a test. This does not necessarily need to be part of "make check" or Travis, but something that can be run separately and just does some automatic tests would make sense, I think.
@laanwj - Good point. I'll create some tests. I'll rework this PR if I have time and submit a new PR if I don't. Any thoughts on where they should go? I feel like perhaps a "test" subfolder would be best. Putting them in qa/rpc-tests or src/test wouldn't really work. Maybe contrib/test could be created so that everything's in one place? I'm open to ideas.
Thanks.
I'd say either putting the test script in contrib/linearize itself or creating a test subfolder in contrib/linearize appeals the most to me. A test directory under contrib would make less sense: the stuff in contrib is so far apart, that grouping things would be next to nonsensical.