Minor corrections in src\test* .
This is a squashed version of #9543, which I accidentally closed while trying to squash and force push.
[Trivial] Grammar and typo correction (laudaa) #9610
pull MarcoFalke wants to merge 1 commits into bitcoin:master from MarcoFalke:Mf1701-laudaa changing 6 files +7 −7-
MarcoFalke commented at 12:27 PM on January 22, 2017: member
-
5c66d41b7f
[Trivial] Grammar and typo correction
Minor corrections in src\test\* .
- MarcoFalke added the label Tests on Jan 22, 2017
- MarcoFalke merged this on Jan 22, 2017
- MarcoFalke closed this on Jan 22, 2017
- MarcoFalke referenced this in commit ff58b1c3bd on Jan 22, 2017
-
ghost commented at 12:29 PM on January 22, 2017: none
Sounds good!
- MarcoFalke deleted the branch on Jan 22, 2017
-
morcos commented at 6:48 PM on February 14, 2017: member
@MarcoFalke for the record I'm opposed to these kind of PR's They just cause unnecessary merge and rebase conflicts for no added value.
-
MarcoFalke commented at 10:00 AM on February 15, 2017: member
@morcos Agree, but note that this pull was already reviewed in #9543. I'd prefer not to close pull request once they have been reviewed and ACKed.
I think one solution would be to mention in our contribution guidelines that minor grammar and spelling mistakes (e.g. AE vs BE or mostly irrelevant typographic errors in non user facing messages) should not be fixed.
-
morcos commented at 1:22 PM on February 15, 2017: member
@MarcoFalke ok thanks.. yeah or fixed only when modifying the area already...
- codablock referenced this in commit 857fd32c6a on Jan 19, 2018
- codablock referenced this in commit 62e5c0ec7a on Jan 20, 2018
- codablock referenced this in commit 6bc16a66fb on Jan 21, 2018
- zkbot referenced this in commit 564a229927 on Apr 4, 2018
- zkbot referenced this in commit dc57d6a7bc on Apr 4, 2018
- andvgal referenced this in commit 5385b8bdef on Jan 6, 2019
- CryptoCentric referenced this in commit 4ad6f79aac on Feb 27, 2019
- DrahtBot locked this on Sep 8, 2021
Contributors
Labels