[refactor] Remove using namespace <xxx> from wallet/ & util* #9643

pull kallewoof wants to merge 2 commits into bitcoin:master from kallewoof:no-using-namespace-wallet-util changing 10 files +349 −368

kallewoof commented at 8:18 AM on January 27, 2017: member

This is a sub-set of #9235, including only the wallet dir and util* files.

Same-binaries check (2017-03-08):

$ ../bitcoin-maintainer-tools/build-for-compare.py 6996e066b538f03b8aa1f617dbb959b57ff6e727 a57845c20e96825f1256e6b7f46d67d205c859e0 --executables "src/bitcoind,src/bitcoin-cli,src/bitcoin-tx"
[...]
make[1]: Leaving directory '/tmp/repo/src'
>>> [do_build] Copying object files...
>>> [do_build] Performing basic analysis pass...
>>> [do_build] Use these commands to compare results:
>>> [do_build] $ sha256sum /tmp/compare/*.stripped
>>> [do_build] $ git diff -W --word-diff /tmp/compare/6996e066b538f03b8aa1f617dbb959b57ff6e727 /tmp/compare/a57845c20e96825f1256e6b7f46d67d205c859e0
$ sha256sum /tmp/compare/*.stripped
1bfe4311525db52b9c5d5c2b0b9ff6f8e3f3cfda0dcb1e5cd83b08b767a4a902  /tmp/compare/bitcoin-cli.6996e066b538f03b8aa1f617dbb959b57ff6e727.stripped
1bfe4311525db52b9c5d5c2b0b9ff6f8e3f3cfda0dcb1e5cd83b08b767a4a902  /tmp/compare/bitcoin-cli.a57845c20e96825f1256e6b7f46d67d205c859e0.stripped
fb0f6796776dc39e422910572a216cbad87f607cbb4920bd12d2c483cc51e231  /tmp/compare/bitcoind.6996e066b538f03b8aa1f617dbb959b57ff6e727.stripped
fb0f6796776dc39e422910572a216cbad87f607cbb4920bd12d2c483cc51e231  /tmp/compare/bitcoind.a57845c20e96825f1256e6b7f46d67d205c859e0.stripped
fe4107fcc49ba17cdfbb0edc357373ea37d833d5691af7b2367758e8b3e1d45c  /tmp/compare/bitcoin-tx.6996e066b538f03b8aa1f617dbb959b57ff6e727.stripped
fe4107fcc49ba17cdfbb0edc357373ea37d833d5691af7b2367758e8b3e1d45c  /tmp/compare/bitcoin-tx.a57845c20e96825f1256e6b7f46d67d205c859e0.stripped
$ git diff -W --word-diff /tmp/compare/6996e066b538f03b8aa1f617dbb959b57ff6e727 /tmp/compare/a57845c20e96825f1256e6b7f46d67d205c859e0
$

The affected files and namespaces:

util.cpp:                 std
utilmoneystr.cpp:         std
utilstrencodings.cpp:     std
utiltime.cpp:             std [unused]
wallet/db.cpp:            std
wallet/rpcdump.cpp:       std
wallet/rpcwallet.cpp:     std
wallet/test/wallet_tests.cpp: std
wallet/wallet.cpp:        std
wallet/walletdb.cpp:      std

fanquake added the label Refactoring on Jan 27, 2017
in src/util.cpp:None in d1382db42d outdated
```
  96 | @@ -97,15 +97,15 @@ namespace boost {
  97 |  
  98 |  } // namespace boost
  99 |  
 100 | -using namespace std;
 101 | +// blank space for binary match
```
dcousens commented at 9:07 AM on January 27, 2017:

?

kallewoof commented at 9:09 AM on January 27, 2017:

The binary check tool trips over the LOCK macros. If a line is removed, the binary check ends up failing.

kallewoof commented at 9:18 AM on January 27, 2017:

In hindsight I realize that comment is very unhelpful. I removed it.
kallewoof force-pushed on Jan 30, 2017
in src/util.cpp:None in df8b24992f outdated
```
  96 | @@ -97,15 +97,15 @@ namespace boost {
  97 |  
  98 |  } // namespace boost
  99 |  
 100 | -using namespace std;
 101 | +
```
jtimon commented at 12:50 AM on February 24, 2017:

Bike-shedding: you could just remove the line.

kallewoof commented at 3:59 AM on February 24, 2017:

Because of macros which use the line number, removing this line breaks the same-binaries-check, unfortunately.
jtimon commented at 1:58 AM on February 24, 2017: contributor

utACK df8b249 Needs rebase
kallewoof force-pushed on Feb 24, 2017
kallewoof commented at 4:39 AM on February 24, 2017: member

Rebased & redid same-binaries check.
laanwj commented at 6:21 AM on March 8, 2017: member

Needs another rebase, sorry.
laanwj assigned laanwj on Mar 8, 2017
Refactor: Remove using namespace <xxx> from wallet/ 8a5228197c
Refactor: Remove using namespace <xxx> from util* a57845c20e
kallewoof force-pushed on Mar 8, 2017
kallewoof commented at 4:56 PM on March 8, 2017: member

@laanwj Rebased & redid same binaries check (6996e066b538f03b8aa1f617dbb959b57ff6e727 vs a57845c20e96825f1256e6b7f46d67d205c859e0). And no worries at all. I knew this might take awhile. :)
laanwj merged this on Mar 9, 2017
laanwj closed this on Mar 9, 2017
laanwj referenced this in commit c047b1663d on Mar 9, 2017
UdjinM6 referenced this in commit 08b5c69eff on Feb 21, 2018
PastaPastaPasta referenced this in commit 3e5713dc69 on Jan 2, 2019
PastaPastaPasta referenced this in commit ad905605a1 on Jan 2, 2019
PastaPastaPasta referenced this in commit 0bc97b2b13 on Jan 2, 2019
PastaPastaPasta referenced this in commit b382e7280e on Jan 3, 2019
andvgal referenced this in commit fd08ebaf3d on Jan 6, 2019
PastaPastaPasta referenced this in commit 0721435a91 on Jan 21, 2019
PastaPastaPasta referenced this in commit 846ef4b889 on Jan 27, 2019
PastaPastaPasta referenced this in commit 3e3abac64d on Jan 29, 2019
CryptoCentric referenced this in commit d191e6b4db on Feb 28, 2019
kallewoof deleted the branch on Oct 17, 2019
DrahtBot locked this on Dec 16, 2021

Contributors

Labels

Linked (view graph)

#9235 [WIP] Refactor: Remove all uses of using namespace in all source files.