Fix typo and spelling inconsistency in CONTRIBUTING.md #9675

pull kokifpen wants to merge 1 commits into bitcoin:master from kokifpen:fix_typo_in_contributing changing 6 files +8 −8

kokifpen commented at 8:15 AM on February 3, 2017: none
Fix some typo and spelling inconsistency in CONTRIBUTING.md.
- Unifying behaviour and behavior
- Fix modularisation to modularization
- Fix GitHub
unknown approved
fanquake added the label Docs and Output on Feb 3, 2017
btcdrak commented at 9:48 AM on February 3, 2017: contributor

NACK. I am the original author and I deliberately used English spelling.
kokifpen commented at 10:21 AM on February 3, 2017: none

@btcdrak Thanks for your comment. In such case, we don't need to change "modularisation" and "behaviour", but we have to change another "behavior", don't we?
MarcoFalke commented at 12:18 PM on February 3, 2017: member

We allow both variants of English to be used. Even in the same file.
ghost commented at 12:39 PM on February 3, 2017: none

That's somewhat inconsistent, but I perfectly understand the reasoning behind it. The only valid change is 'GitHub'? If the author is planning on doing more of these, then they should probably combine them.
kokifpen commented at 2:01 PM on February 3, 2017: none

Thanks for discussion about this. I removed unnecessary changes. And I fixed some GitHub spelling issues in other files.
btcdrak commented at 3:58 PM on February 7, 2017: contributor

Looks good d788f38 :+1:
instagibbs commented at 4:32 PM on February 7, 2017: member

ACK, could you squash?

in doc/translation_process.md:None in d788f38a91 outdated

   3 | @@ -4,7 +4,7 @@ Translations
   4 |  The Bitcoin-Core project has been designed to support multiple localisations. This makes adding new phrases, and completely new languages easily achievable. For managing all application translations, Bitcoin-Core makes use of the Transifex online translation management tool.
   5 |  
   6 |  ### Helping to translate (using Transifex)
   7 | -Transifex is setup to monitor the Github repo for updates, and when code containing new translations is found, Transifex will process any changes. It may take several hours after a pull-request has been merged, to appear in the Transifex web interface.
   8 | +Transifex is setup to monitor the GitHub repo for updates, and when code containing new translations is found, Transifex will process any changes. It may take several hours after a pull-request has been merged, to appear in the Transifex web interface.

paveljanik commented at 5:30 PM on February 7, 2017:

There is a second instance of Github in this file, please fix it too (https://github.com/bitcoin/bitcoin/pull/9675/files#diff-eb26390875720fc65e1c6c74a87626ffR35).

kokifpen commented at 7:19 AM on February 8, 2017:

@paveljanik Thanks for letting me know! I fixed it too.

kokifpen commented at 7:19 AM on February 8, 2017: none

Fix one more GitHub spelling.
MarcoFalke commented at 12:09 PM on February 8, 2017: member

Please squash your commits according to https://github.com/bitcoin/bitcoin/blob/master/CONTRIBUTING.md#squashing-commits

Fix typo and spelling inconsistency in CONTRIBUTING.md

Fix spellings of GitHub

Remove unnecessary changes

Fix GitHub spelling on doc/translation_process.md

36164faa33

kokifpen force-pushed on Feb 9, 2017
kokifpen commented at 2:59 AM on February 9, 2017: none

@MarcoFalke Done. Thanks for notifying me about squashing.
paveljanik commented at 11:06 AM on February 9, 2017: contributor

ACK https://github.com/bitcoin/bitcoin/pull/9675/commits/36164faa338d387177c6328496f63ac11eda3b78
unknown approved
laanwj merged this on Feb 16, 2017
laanwj closed this on Feb 16, 2017
laanwj referenced this in commit afae75fd3d on Feb 16, 2017
codablock referenced this in commit 3c542cd269 on Jan 19, 2018
codablock referenced this in commit 5f88c6451d on Jan 23, 2018
andvgal referenced this in commit c89ecdeb0c on Jan 6, 2019
CryptoCentric referenced this in commit e6a8996bfe on Feb 27, 2019
laanwj deleted a comment on Oct 9, 2019
DrahtBot locked this on Dec 16, 2021

Contributors

Labels