Remove unicode characters from RPC user and password in QA tests #9706

pull jnewbery wants to merge 1 commits into bitcoin:master from jnewbery:rpctestuser changing 1 files +1 −1

jnewbery commented at 2:21 PM on February 7, 2017: member

The characters are cute, but they're difficult to type into bitcoin-cli if you need to halt the test and manually issue RPCs to the node under test.

Remove unicode characters from RPC user and password in QA tests

The characters are cute, but they're difficult to type into bitcoin-cli
if you need to halt the test and manually issue RPCs to the node under
test.

0d8fd209fd

laanwj commented at 2:22 PM on February 7, 2017: member

They're there for a purpose: to test that unicode values work in the user/password. This is important for supporting non-English languages.

Why would you ever need to type them manually, instead of just pointing bitcoin-cli at the right .conf file??
laanwj added the label RPC/REST/ZMQ on Feb 7, 2017
jnewbery commented at 3:29 PM on February 7, 2017: member

You're right - using the bitcoin-cli -conf option makes sense. Thanks!
jnewbery closed this on Feb 7, 2017
jnewbery deleted the branch on Feb 7, 2017
MarcoFalke locked this on Sep 8, 2021

Contributors

Labels