devtools: Handle Qt formatting characters edge-case in update-translations.py #9735

1. 
   laanwj commented at 9:04 AM on February 10, 2017: member

   If both numeric format specifiers and "others" are used, assume we're dealing with a Qt-formatted message. In the case of Qt formatting (see https://doc.qt.io/qt-5/qstring.html#arg) only numeric formats are replaced at all. This means (percentage: %1%) is valid (which was introduced in #9461), without needing any kind of escaping that would be necessary for strprintf. Without this, this function would wrongly detect %) as a printf format specifier (and an assertion triggers).

   Also contains periodic translations update from Transifex.

2. devtools: Handle Qt formatting characters edge-case in update-translations.py

   If both numeric format specifiers and "others" are used, assume we're
   dealing with a Qt-formatted message. In the case of Qt formatting (see
   https://doc.qt.io/qt-5/qstring.html#arg) only numeric formats are
   replaced at all. This means "(percentage: %1%)" is valid (which was
   introduced in #9461), without needing any kind of escaping that would be
   necessary for strprintf.  Without this, this function would wrongly
   detect '%)' as a printf format specifier.

   5e903a5ed9
3. qt: Periodic translations update 7179e7ca0d
4. laanwj added the label GUI on Feb 10, 2017
5. laanwj added this to the milestone 0.14.0 on Feb 11, 2017
6. 
   jonasschnelli commented at 2:06 PM on February 12, 2017: contributor

   Looks good to me: 7179e7ca0db493dccbfd88f64738252844aab6ff

7. 
   theuni commented at 12:42 AM on February 14, 2017: member

   ACK 7179e7ca0db493dccbfd88f64738252844aab6ff

8. laanwj merged this on Feb 14, 2017
9. laanwj closed this on Feb 14, 2017

   ---

10. laanwj referenced this in commit ec66d06e6e on Feb 14, 2017
11. codablock referenced this in commit 51f6a91915 on Jan 19, 2018
12. codablock referenced this in commit b183a1f2a3 on Jan 23, 2018
13. andvgal referenced this in commit 5c75c17d0a on Jan 6, 2019
14. CryptoCentric referenced this in commit 461373f74d on Feb 27, 2019
15. DrahtBot locked this on Sep 8, 2021

Milestone
0.14.0