Check minversion before loading the rest of the wallet #975

pull sipa wants to merge 1 commits into bitcoin:master from sipa:versioncheck changing 1 files +8 −8

sipa commented at 4:06 AM on March 22, 2012: member

When a 0.6 wallet with compressed pubkeys is created, it writes a minversion record to prevent older clients from reading it. If the 0.5 loading it sees a key record before seeing the minversion record however, it will fail with DB_CORRUPT instead of DB_TOO_NEW.

This is more needed in backports than in mainline for now, but it's code improvement in any case.

Check minversion before loading the rest of the wallet

When a 0.6 wallet with compressed pubkeys is created, it writes a
minversion record to prevent older clients from reading it. If the 0.5
loading it sees a key record before seeing the minversion record however,
it will fail with DB_CORRUPT instead of DB_TOO_NEW.

ef12c2184d

gavinandresen commented at 1:04 PM on March 22, 2012: contributor

ACK, planning ahead for future upgrades is something we need to get better at.
gavinandresen referenced this in commit e12d131734 on Mar 22, 2012
gavinandresen merged this on Mar 22, 2012
gavinandresen closed this on Mar 22, 2012
coblee referenced this in commit a6b0f4430c on Jul 17, 2012
ptschip referenced this in commit b345798694 on Feb 26, 2018
lateminer referenced this in commit 9765a772b8 on Oct 30, 2019
DrahtBot locked this on Sep 8, 2021

Contributors

sipa

gavinandresen