Bugfix: Qt/Options: Restore persistent "restart required" notice #9755

pull luke-jr wants to merge 1 commits into bitcoin:master from luke-jr:bugfix_gui_opts_restartreq changing 1 files +4 −1
  1. luke-jr commented at 10:51 PM on February 13, 2017: member

    This got broken when updateProxyValidationState was added.

  2. Bugfix: Qt/Options: Restore persistent "restart required" notice 0b4f273e9c
  3. fanquake added the label GUI on Feb 14, 2017
  4. laanwj commented at 11:32 AM on February 14, 2017: member

    What exactly is broken here?

  5. luke-jr commented at 11:52 AM on February 14, 2017: member

    updateProxyValidationState clears it, so the persistent message is never shown in practice

  6. laanwj added this to the milestone 0.14.0 on Feb 14, 2017
  7. laanwj commented at 2:06 PM on February 14, 2017: member

    That seems pretty serious, tagging for 0.14

  8. jonasschnelli commented at 2:07 PM on February 14, 2017: contributor

    Started testing...

  9. jonasschnelli commented at 2:31 PM on February 14, 2017: contributor

    Thanks @luke-jr! Tested ACK 0b4f273e9cf7166dbd103e116b5d991e359e673d. Indeed, this is an important fix for 0.14.

  10. jonasschnelli commented at 2:34 PM on February 14, 2017: contributor

    Issue was introduced in #7025.

  11. MarcoFalke commented at 2:55 PM on February 14, 2017: member

    utACK 0b4f273e9cf7166dbd103e116b5d991e359e673d

  12. jonasschnelli merged this on Feb 14, 2017
  13. jonasschnelli closed this on Feb 14, 2017

  14. jonasschnelli referenced this in commit a441db01b5 on Feb 14, 2017
  15. codablock referenced this in commit be1166c6a2 on Jan 19, 2018
  16. codablock referenced this in commit 132edbda8c on Jan 23, 2018
  17. andvgal referenced this in commit 32dea67529 on Jan 6, 2019
  18. CryptoCentric referenced this in commit e03554cb2f on Feb 27, 2019
  19. DrahtBot locked this on Sep 8, 2021
Labels

Milestone
0.14.0


github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-14 15:15 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me