wallet: Prevent “overrides a member function but is not marked ‘override’” warnings #9764

1. 
   laanwj commented at 10:38 am on February 15, 2017: member

   Because it is used inconsistently in a single class at least version 5.4.0 of g++ to complains about methods that don’t use override. I get a ton of these warnings in everything that includes wallet.h. There is two ways to go about this: remove override from the methods having it, or add it to the methods missing it. I chose the second. (a third would be to disable the warning completely or selectively, but I don’t think that’s called for)
2. wallet: Prevent "overrides a member function but is not marked 'override'" warnings

   Because it is used inconsistently at least version 5.4.0 of g++ to
   complains about methods that don't use override. There is two ways to go
   about this: remove override from the methods having it, or add it to the
   methods missing it. I chose the second.

   6c5427d24c
3. laanwj added the label Wallet on Feb 15, 2017
4. 
   paveljanik commented at 10:49 am on February 15, 2017: contributor

   This removes approx. 2000 lines from my build logs! ;-)

   ACK https://github.com/bitcoin/bitcoin/pull/9764/commits/6c5427d24ca18ce01e46242876e24f68a9c72cc3

5. laanwj merged this on Feb 16, 2017
6. laanwj closed this on Feb 16, 2017

   ---

7. laanwj referenced this in commit f8af89a918 on Feb 16, 2017
8. codablock referenced this in commit d568b73b5e on Jan 31, 2018
9. codablock referenced this in commit 7dc7f94087 on Jan 31, 2018
10. codablock referenced this in commit 72c8eb3644 on Jan 31, 2018
11. codablock referenced this in commit 75421c37b6 on Feb 1, 2018
12. andvgal referenced this in commit aef4690bfe on Jan 6, 2019
13. CryptoCentric referenced this in commit 6004b06ad8 on Feb 28, 2019
14. CryptoCentric referenced this in commit 7a15bf033e on Mar 2, 2019
15. DrahtBot locked this on Sep 8, 2021

Contributors
laanwj paveljanik

Labels
Wallet