Bitcoin-Qt doesn't show some transactions #978

luke-jr commented at 11:40 PM on March 22, 2012: member

I just received a payout from Eligius, and it isn't visible in Bitcoin-Qt despite having 14 confirmations now. My client is up to date, and debug.log shows one entry with the txid. I don't know if it's the same bug, but I have seen the same thing happen with normal (ie, non-generated) sends as well in the past. I have not restarted my client, as I wish to debug this issue. I know it will show up if I use -rescan, at least. What can I try to do to look into this further?

  got inventory: block 0000000000000635c404  new (from 78.47.187.252:8333 at lld)
askfor block 0000000000000635c404   0
sending getdata: block 0000000000000635c404
  got inventory: block 0000000000000635c404  new (from 173.242.112.53:8333 at lld)
askfor block 0000000000000635c404   1332450345000000
  got inventory: block 0000000000000635c404  new (from 86.123.208.149:2295 at lld)
askfor block 0000000000000635c404   1332450465000000
  got inventory: block 0000000000000635c404  new (from 37.53.212.44:4990 at lld)
askfor block 0000000000000635c404   1332450585000000
  got inventory: block 0000000000000635c404  new (from 58.218.194.54:8333 at lld)
askfor block 0000000000000635c404   1332450705000000
  got inventory: block 0000000000000635c404  new (from 79.160.173.76:8333 at lld)
askfor block 0000000000000635c404   1332450825000000
  got inventory: block 0000000000000635c404  new (from 79.119.186.169:58716 at lld)
askfor block 0000000000000635c404   1332450945000000
  got inventory: block 0000000000000635c404  new (from 98.143.152.14:8333 at lld)
askfor block 0000000000000635c404   1332451065000000
  got inventory: block 0000000000000635c404  new (from 93.183.165.168:3739 at lld)
askfor block 0000000000000635c404   1332451185000000
  got inventory: block 0000000000000635c404  new (from 94.244.165.242:3740 at lld)
askfor block 0000000000000635c404   1332451305000000
  got inventory: block 0000000000000635c404  new (from 188.213.165.168:55608 at lld)
askfor block 0000000000000635c404   1332451425000000
  got inventory: block 0000000000000635c404  new (from 188.2.196.250:53359 at lld)
askfor block 0000000000000635c404   1332451545000000
  got inventory: block 0000000000000635c404  new (from 64.121.179.145:59044 at lld)
askfor block 0000000000000635c404   1332451665000000
  got inventory: block 0000000000000635c404  new (from 178.165.57.47:50312 at lld)
askfor block 0000000000000635c404   1332451785000000
  got inventory: block 0000000000000635c404  new (from 91.218.14.211:54616 at lld)
askfor block 0000000000000635c404   1332451905000000
  got inventory: block 0000000000000635c404  new (from 12.238.60.18:65235 at lld)
askfor block 0000000000000635c404   1332452025000000
  got inventory: block 0000000000000635c404  new (from 109.87.251.12:50378 at lld)
askfor block 0000000000000635c404   1332452145000000
  got inventory: block 0000000000000635c404  new (from 213.111.134.248:60351 at lld)
askfor block 0000000000000635c404   1332452265000000
  got inventory: block 0000000000000635c404  new (from 86.106.45.91:58416 at lld)
askfor block 0000000000000635c404   1332452385000000
  got inventory: block 0000000000000635c404  new (from 78.106.27.121:56307 at lld)
askfor block 0000000000000635c404   1332452505000000
  got inventory: block 0000000000000635c404  new (from 89.161.86.41:2817 at lld)
askfor block 0000000000000635c404   1332452625000000
  got inventory: block 0000000000000635c404  new (from 2.95.50.155:3893 at lld)
askfor block 0000000000000635c404   1332452745000000
  got inventory: block 0000000000000635c404  new (from 46.72.112.247:4057 at lld)
askfor block 0000000000000635c404   1332452865000000
  got inventory: block 0000000000000635c404  new (from 31.43.136.187:50750 at lld)
askfor block 0000000000000635c404   1332452985000000
  got inventory: block 0000000000000635c404  new (from 83.25.114.155:55088 at lld)
askfor block 0000000000000635c404   1332453105000000
  got inventory: block 0000000000000635c404  new (from 31.200.146.143:55700 at lld)
askfor block 0000000000000635c404   1332453225000000
  got inventory: block 0000000000000635c404  new (from 178.54.44.75:4447 at lld)
askfor block 0000000000000635c404   1332453345000000
  got inventory: block 0000000000000635c404  new (from 178.148.230.214:15297 at lld)
askfor block 0000000000000635c404   1332453465000000
  got inventory: block 0000000000000635c404  new (from 69.118.191.16:52908 at lld)
askfor block 0000000000000635c404   1332453585000000
  got inventory: block 0000000000000635c404  new (from 95.104.125.39:54654 at lld)
askfor block 0000000000000635c404   1332453705000000
  got inventory: block 0000000000000635c404  new (from 213.111.99.134:52129 at lld)
askfor block 0000000000000635c404   1332453825000000
  got inventory: block 0000000000000635c404  new (from 31.41.15.55:57053 at lld)
askfor block 0000000000000635c404   1332453945000000
  got inventory: block 0000000000000635c404  new (from 208.111.165.68:8333 at lld)
askfor block 0000000000000635c404   1332454065000000
  got inventory: block 0000000000000635c404  new (from 95.26.136.103:61725 at lld)
askfor block 0000000000000635c404   1332454185000000
  got inventory: block 0000000000000635c404  new (from 89.137.70.13:57000 at lld)
askfor block 0000000000000635c404   1332454305000000
  got inventory: block 0000000000000635c404  new (from 77.45.33.44:54590 at lld)
askfor block 0000000000000635c404   1332454425000000
received block 0000000000000635c404
accepted connection 46.98.141.14:59774
AddToWallet 413cf84c6d  new
SetBestChain: new best=0000000000000635c404  height=172396  work=271409372764954907121
ProcessBlock: ACCEPTED
  got inventory: block 0000000000000635c404  have (from 66.188.101.2:8333 at lld)
askfor block 0000000000000635c404   0

sipa commented at 11:46 PM on March 22, 2012: member

Does listtransactions show it? Or did you start without -server?

luke-jr commented at 11:51 PM on March 22, 2012: member

Yes, listtransactions shows it.

luke-jr commented at 12:55 AM on March 23, 2012: member

(gdb) printf "%d\n", pwalletMain->vWalletUpdated.empty()
Program received signal SIGSEGV, Segmentation fault.

:(

Starting Bitcoin-Qt again shows it, I did not need to rescan.

Assuming QTimer works correctly, I think the problem must lie in TransactionTablePriv::updateWallet

luke-jr referenced this in commit cef67572d0 on Mar 23, 2012

laanwj commented at 7:11 AM on March 23, 2012: member

DecomposeTransaction (and associated function showTransaction) decide whether transactions are visible or not in the UI:

https://github.com/bitcoin/bitcoin/blob/master/src/qt/transactionrecord.cpp

It might have something to do with the block chain depth check that happens there. Maybe if a coinbase transaction is rejected the first time, it is not added later on when the chain advances.

laanwj commented at 7:45 AM on March 24, 2012: member

Eligius payouts are coinbase transactions right?

luke-jr commented at 1:57 PM on March 24, 2012: member

Right, though as I mentioned, I'm pretty sure I've seen this occur with non-generation too.

laanwj commented at 9:16 AM on March 25, 2012: member

If you don't trust the QTimer you may be interested in this commit in my sandbox, it removes the timers and updates the transaction list / address book when asked to by the core. Also fixes the problem that address created through rpc don't appear in the ui.

https://github.com/laanwj/bitcoin/commit/8228c8d7d5a070d16939e29bf5b2988156116a1a

laanwj commented at 7:56 AM on May 15, 2012: member

This should be solved by #1205, which allows for re-visiting transaction visibility. Mined transactions will become visible after they reach block depth 2.

luke-jr commented at 8:14 AM on May 15, 2012: member

They should be visible at depth 1...?

laanwj commented at 8:22 AM on May 15, 2012: member

Maybe. But I haven't changed that part from the Satoshi client.

laanwj commented at 8:25 AM on May 15, 2012: member

Uh, you're right... its <2, not <=2, see https://github.com/bitcoin/bitcoin/blob/master/src/qt/transactionrecord.cpp#L22

laanwj closed this on Aug 18, 2012

laanwj commented at 8:36 AM on August 18, 2012: member

Closing this issue; the wallet update code has been overhauled and this should no longer happen (and if it happens we have useful debug.log output).

MarcoFalke locked this on Sep 8, 2021