Probably copy paste error introduced in #9657.
qa: Set correct path for binaries in rpc tests #9823
pull MarcoFalke wants to merge 1 commits into bitcoin:master from MarcoFalke:Mf1702-qaPath changing 1 files +1 −1-
MarcoFalke commented at 9:50 AM on February 22, 2017: member
-
qa: Set correct path for binaries in rpc tests 3333ad0b63
- laanwj added the label Tests on Feb 22, 2017
-
jnewbery commented at 5:42 PM on February 22, 2017: member
tested ACK. Out of interest, was this causing issues?
Minor suggestion: you've used the str.format() method here, and the line immediately below uses a C-style string specifier for the same variable. Perhaps use the same syntax for both? (I don't care which)
-
MarcoFalke commented at 6:14 PM on February 22, 2017: member
was this causing issues
Yes, when running the tests with a binary of different name, such as
bitcoin-qt. See #7209 or tryBITCOIND=bitcoin-qt ./qa/pull-tester/rpc-tests.py. -
MarcoFalke commented at 4:35 PM on February 23, 2017: member
re style nit: Personally I think the new style format method looks nicer, but I think everyone is free to use whatever they prefer as long as changes only happen when the code is touched anyway. (No "qa: Unify format methods" pulls please)
- MarcoFalke merged this on Feb 23, 2017
- MarcoFalke closed this on Feb 23, 2017
- MarcoFalke referenced this in commit a13a417cdc on Feb 23, 2017
- MarcoFalke deleted the branch on Feb 23, 2017
- PastaPastaPasta referenced this in commit 6db9d60402 on Dec 28, 2018
- PastaPastaPasta referenced this in commit 5049fdd831 on Dec 29, 2018
- PastaPastaPasta referenced this in commit de77c5ad13 on Dec 29, 2018
- PastaPastaPasta referenced this in commit 6a305cd12c on Dec 29, 2018
- PastaPastaPasta referenced this in commit 97e0720391 on Jan 2, 2019
- PastaPastaPasta referenced this in commit 1afe9fc94e on Jan 3, 2019
- PastaPastaPasta referenced this in commit 72035d161a on Jan 3, 2019
- UdjinM6 referenced this in commit 07dcddb4ca on Jan 7, 2019
- zkbot referenced this in commit 025bd44543 on Nov 21, 2020
- zkbot referenced this in commit 7a0a268054 on Dec 2, 2020
- zkbot referenced this in commit c8896f9907 on Dec 2, 2020
- DrahtBot locked this on Sep 8, 2021
