Trivial: fix comments referencing AppInit2 #9833

pull benma wants to merge 1 commits into bitcoin:master from benma:stalecomments changing 3 files +5 −8

benma commented at 7:40 AM on February 23, 2017: none

It was refactored into multiple functions in 0cc8b6bc44bea29e24fa4e13d8a9bbe4f1483680.
in src/init.cpp:None in c02681cc65 outdated
```
 187 | @@ -188,7 +188,7 @@ void Shutdown()
 188 |      if (!lockShutdown)
 189 |          return;
 190 |  
 191 | -    /// Note: Shutdown() must be able to handle cases in which AppInit2() failed part of the way,
 192 | +    /// Note: Shutdown() must be able to handle cases in which AppInitMain() failed part of the way,
```
laanwj commented at 8:31 AM on February 23, 2017:

let's just remove mention of a function here and call it "initialization". It may be any of the initialization-related functions that failed.

benma commented at 8:46 AM on February 23, 2017:

Done (also in bitcoin.cpp).

For my information: how should I address feedback: with new commits for easier review, or with amending? I amended this time.

laanwj commented at 8:52 AM on February 23, 2017:

For documentation/string commits like this, amending is best IMO. For more involved commits, it can make sense to keep a history, at least until merge.
benma force-pushed on Feb 23, 2017
jonasschnelli added the label Docs and Output on Feb 23, 2017

in src/init.cpp:None in 6c8294f33a outdated

 117 | @@ -118,7 +118,7 @@ static const char* FEE_ESTIMATES_FILENAME="fee_estimates.dat";
 118 |  // threads that should only be stopped after the main network-processing
 119 |  // threads have exited.
 120 |  //
 121 | -// Note that if running -daemon the parent process returns from AppInit2
 122 | +// Note that if running -daemon the parent process returns from AppInitMain()

laanwj commented at 9:44 AM on February 23, 2017:

This is no longer true, by the way. Since #9010, the -daemon handling is in bitcoind.cpp, not in init.cpp.

benma commented at 12:20 AM on February 24, 2017:

Thanks. The comment seems to not be true anyway, so I removed it altogether.

Trivial: fix comments referencing AppInit2

It was refactored into multiple functions in
0cc8b6bc44bea29e24fa4e13d8a9bbe4f1483680.

ef9f495e93

benma force-pushed on Feb 24, 2017
sipa commented at 3:32 AM on February 24, 2017: member

utACK ef9f495e931fad1e356757d6a40092596aa0205c
paveljanik commented at 9:23 AM on February 24, 2017: contributor

utACK ef9f495
laanwj merged this on Feb 24, 2017
laanwj closed this on Feb 24, 2017
laanwj referenced this in commit dd6e0d6301 on Feb 24, 2017
PastaPastaPasta referenced this in commit abd505230e on Dec 28, 2018
PastaPastaPasta referenced this in commit 7d3390f6b0 on Dec 29, 2018
PastaPastaPasta referenced this in commit 1f66681632 on Dec 29, 2018
PastaPastaPasta referenced this in commit e82e5548fd on Dec 29, 2018
PastaPastaPasta referenced this in commit 3cec40c56c on Jan 2, 2019
PastaPastaPasta referenced this in commit 1895872a7f on Jan 3, 2019
PastaPastaPasta referenced this in commit 3e1a3fea38 on Jan 3, 2019
UdjinM6 referenced this in commit 07dcddb4ca on Jan 7, 2019
DrahtBot locked this on Sep 8, 2021

Contributors

Labels