Fix RPC failure testing (continuation of #9707) #9842

1. 
   jnewbery commented at 8:16 pm on February 23, 2017: member

   Commit 9db8eecac1c713c760c0217b6acb7455c657fa8b improved the assert_raises_jsonrpc() function for better testing of RPC failure modes. This commit continues the job by removing remaining broken try-except RPC testing from individual test cases and replacing it with calls to assert_raises_jsonrpc().

   Note that this does not fully complete the job. This commit replaces the try/except code with assert_raises_jsonrpc() only for those test cases where no changes to bitcoind were required (ie the test cases weren’t necessarily fully testing the behaviour, but the behaviour was correct anyway). For any test cases where fixing the test code has revealed bugs or inconsistencies, I’ll raise a separate issue/PR (eg #9738, #9714, #9841, #9710). There are a few more of those to come.

2. fanquake added the label RPC/REST/ZMQ on Feb 23, 2017
3. fanquake added the label Tests on Feb 23, 2017
4. 
   jonasschnelli commented at 9:32 am on February 28, 2017: contributor

   Thanks for the cleanup. Factor out the try/catches makes the tests much more readable. utACK f59cacd0e0e210783bc7eace5e317a7b466f719b
5. laanwj assigned laanwj on Mar 6, 2017
6. in qa/rpc-tests/blockchain.py: in f59cacd0e0 outdated

   18+    assert_raises_jsonrpc,
   19     assert_is_hex_string,
   20     assert_is_hash_string,
   21     start_nodes,
   22-    connect_nodes_bi,
   23+    connect_nodes_bi
   

   ---

   ---

   

   jtimon commented at 5:59 pm on March 7, 2017:

   I don’t think you need to remove the coma here.
7. jnewbery force-pushed on Mar 7, 2017
8. 
   jnewbery commented at 7:20 pm on March 7, 2017: member

   rebased and reverted the comma removal: https://github.com/jnewbery/bitcoin/commit/c3d6c83d67f2b50b17c93ffb74559420a7cfb9ba / https://github.com/jnewbery/bitcoin/tree/pr9842.2
9. jnewbery force-pushed on Mar 7, 2017
10. 
    jnewbery commented at 9:27 pm on March 7, 2017: member

    Bad rebase. Rebased to https://github.com/jnewbery/bitcoin/commit/4b7749550657ace31e91f56fc336ced532605f74 / https://github.com/jnewbery/bitcoin/tree/pr9842.3
11. 
    jnewbery commented at 7:53 pm on March 8, 2017: member

    oops. Merge issues from priority removal. Should be fixed now.
12. jnewbery force-pushed on Mar 9, 2017
13. jnewbery force-pushed on Mar 9, 2017
14. 
    jnewbery commented at 8:31 pm on March 9, 2017: member

    rebased
15. Fix RPC failure testing (2 of 2)

    Commit 9db8eecac1c713c760c0217b6acb7455c657fa8b improved the
    assert_raises_jsonrpc() function for better testing of RPC failure
    modes. This commit completes the job by removing remaining broken
    try-except RPC testing from the individual test cases and replacing it
    with calls to assert_raises_jsonrpc().

    c9bd0f6421
16. jnewbery force-pushed on Mar 15, 2017
17. 
    jnewbery commented at 4:28 pm on March 15, 2017: member

    rebased. Any chance of getting this merged soon?
18. 
    MarcoFalke commented at 10:56 am on March 16, 2017: member

    utACK c9bd0f64212cd600daf30c9c59035bfe9f07b81b
19. MarcoFalke merged this on Mar 16, 2017
20. MarcoFalke closed this on Mar 16, 2017

    ---

21. MarcoFalke referenced this in commit 598ef9c44b on Mar 16, 2017
22. PastaPastaPasta referenced this in commit 8baa01557f on Jan 2, 2019
23. PastaPastaPasta referenced this in commit f755b61918 on Jan 2, 2019
24. PastaPastaPasta referenced this in commit 3d50098051 on Jan 2, 2019
25. PastaPastaPasta referenced this in commit 6bd7fb56b2 on Jan 3, 2019
26. PastaPastaPasta referenced this in commit 4655f69938 on Jan 21, 2019
27. PastaPastaPasta referenced this in commit c4736b6f57 on Jan 29, 2019
28. PastaPastaPasta referenced this in commit a8aaa0ba89 on Mar 10, 2019
29. PastaPastaPasta referenced this in commit fc1878bca3 on Mar 10, 2019
30. PastaPastaPasta referenced this in commit 97bcbff227 on Mar 11, 2019
31. PastaPastaPasta referenced this in commit 3c5707fb00 on Mar 11, 2019
32. PastaPastaPasta referenced this in commit 7b0da09fc4 on Mar 12, 2019
33. PastaPastaPasta referenced this in commit 9c5233dd39 on Mar 13, 2019
34. UdjinM6 referenced this in commit a16144ee23 on Mar 13, 2019
35. PastaPastaPasta referenced this in commit effc8bffd7 on Mar 13, 2019
36. PastaPastaPasta referenced this in commit ef74ded65d on Mar 14, 2019
37. PastaPastaPasta referenced this in commit 0b8012bd55 on Mar 14, 2019
38. PastaPastaPasta referenced this in commit 8af32ca017 on Mar 15, 2019
39. PastaPastaPasta referenced this in commit 0005b68c69 on Mar 16, 2019
40. PastaPastaPasta referenced this in commit 39560b42d0 on Apr 3, 2019
41. PastaPastaPasta referenced this in commit 319f4a63b9 on Apr 3, 2019
42. PastaPastaPasta referenced this in commit c825949e0c on Apr 5, 2019
43. PastaPastaPasta referenced this in commit 5ae202da96 on May 6, 2019
44. barrystyle referenced this in commit 2688d58dff on Jan 22, 2020
45. MarcoFalke locked this on Sep 8, 2021

Contributors
jnewbery jonasschnelli jtimon MarcoFalke

Labels
Tests RPC/REST/ZMQ