remove 'label' filter for rpc command help #9894

pull instagibbs wants to merge 1 commits into bitcoin:master from instagibbs:filterrpc changing 1 files +0 −3

instagibbs commented at 12:20 AM on March 1, 2017: member

No idea why it's there(which gives me some pause) since it's a sourceforge-era commit, but it seems useless and filters out any command with "label" in the name.
fanquake added the label RPC/REST/ZMQ on Mar 1, 2017
in src/rpc/server.cpp:None in 91321e63e0 outdated
```
 193 | @@ -194,8 +194,6 @@ std::string CRPCTable::help(const std::string& strCommand) const
 194 |          const CRPCCommand *pcmd = command.second;
 195 |          string strMethod = pcmd->name;
 196 |          // We already filter duplicates, but these deprecated screw up the sort order
```
dcousens commented at 12:59 AM on March 1, 2017:

is this comment relevant?

instagibbs commented at 1:00 AM on March 1, 2017:

It used to have other deprecated commands, long-ago deleted. I'm not actually sure what the comment is trying to say. (no commits to be seen on git makes it harder)

laanwj commented at 9:43 AM on March 1, 2017:

Yes please remove the comment too
laanwj commented at 9:45 AM on March 1, 2017: member

Eh yes this is old cruft, we certainly don't want to remove label commands from the help. You've potentially saved me a hour of frustrating debugging for #7729. utACK https://github.com/bitcoin/bitcoin/pull/9894/commits/91321e63e0dbdabae682b7455329fded8aa576af.
remove 'label' filter for rpc command help 666597798c
instagibbs force-pushed on Mar 1, 2017
instagibbs commented at 5:16 PM on March 1, 2017: member

Removed the comment as well.

I was a bit surprised that this had never come up for #7729, heh
MarcoFalke commented at 5:44 PM on March 1, 2017: member

utACK 6665977
jnewbery commented at 11:14 PM on March 1, 2017: member

Tested ACK https://github.com/bitcoin/bitcoin/pull/9894/commits/666597798c07d9df06681be63d2b2f51f0d5ca8a

Travis has been timing out all day. The failure isn't due to this PR.
jonasschnelli commented at 8:28 AM on March 2, 2017: contributor

utACK 666597798c07d9df06681be63d2b2f51f0d5ca8a
paveljanik commented at 8:49 AM on March 2, 2017: contributor

ACK https://github.com/bitcoin/bitcoin/commit/666597798c07d9df06681be63d2b2f51f0d5ca8a
laanwj merged this on Mar 2, 2017
laanwj closed this on Mar 2, 2017
laanwj referenced this in commit 0496e15aef on Mar 2, 2017
luke-jr commented at 9:14 AM on March 2, 2017: member

For historical reference: IIRC, the RPCs were originally label, and had been replaced by the account variants.
laanwj commented at 2:45 PM on March 3, 2017: member

For historical reference: IIRC, the RPCs were originally label, and had been replaced by the account variants.

Interesting. So we're going full circle.
PastaPastaPasta referenced this in commit 870930a20b on Dec 29, 2018
PastaPastaPasta referenced this in commit 7d40556ba2 on Dec 30, 2018
PastaPastaPasta referenced this in commit f3fa1161aa on Dec 30, 2018
PastaPastaPasta referenced this in commit 6b9cdb1e92 on Dec 30, 2018
PastaPastaPasta referenced this in commit 63a07bd4f3 on Dec 31, 2018
PastaPastaPasta referenced this in commit a5e4b86a17 on Dec 31, 2018
PastaPastaPasta referenced this in commit e0f47a9d2e on Jan 2, 2019
PastaPastaPasta referenced this in commit e5b3b0a713 on Jan 2, 2019
PastaPastaPasta referenced this in commit 539aece9d4 on Jan 3, 2019
PastaPastaPasta referenced this in commit 1e39b92254 on Jan 3, 2019
PastaPastaPasta referenced this in commit a0bbb2fb61 on Jan 5, 2019
PastaPastaPasta referenced this in commit 90f6607ab5 on Jan 5, 2019
PastaPastaPasta referenced this in commit 7a92dbd9e9 on Jan 7, 2019
PastaPastaPasta referenced this in commit f7d6aa629b on Jan 7, 2019
PastaPastaPasta referenced this in commit 64e70cfd25 on Jan 7, 2019
PastaPastaPasta referenced this in commit aa4054322a on Jan 7, 2019
PastaPastaPasta referenced this in commit 07b50aefa2 on Jan 23, 2019
PastaPastaPasta referenced this in commit 02f4661b3c on Jan 23, 2019
PastaPastaPasta referenced this in commit c80bcab06e on Jan 25, 2019
PastaPastaPasta referenced this in commit d161f905fe on Jan 25, 2019
MarcoFalke locked this on Sep 8, 2021

Contributors

Labels