[0.14] Allow any subkey in verify-commits (BlueMatt) #9920

pull MarcoFalke wants to merge 1 commits into bitcoin:0.14 from MarcoFalke:Mf1703-verifySubkeys changing 2 files +3 −3
  1. MarcoFalke commented at 1:13 AM on March 5, 2017: member

    This replaces the fingerprints of the trusted keys which are subkeys by the fingerprint of their root key and then relaxes verify-commits to accept the root key or any of its subkeys.

    Stolen from #9880 @laanwj This should fix the travis issue. You can merge the same branch to master via https://github.com/bitcoin/bitcoin/compare/master...MarcoFalke:Mf1703-verifySubkeys

  2. Allow any subkey in verify-commits 589cd63b30
  3. MarcoFalke added the label Scripts and tools on Mar 5, 2017
  4. laanwj commented at 11:24 AM on March 5, 2017: member

    This would prohibit designating certain subkeys for the specific purpose of signing commits? On the other hand the added overhead (and travis failures) of keeping track of that on the project level may not be worth it. So I'm okay with this.

  5. MarcoFalke commented at 11:44 AM on March 5, 2017: member

    Jup, the script no longer encourages you to use only the specifically hardcoded subkey for signing commits. You are now free to create several subkeys and use any of them (or even the root key, which I would not recommend).

  6. laanwj commented at 1:33 PM on March 5, 2017: member

    ACK 589cd63, verified that the added key fingerprints 133EAC179436F14A5CF1B794860FEB804E669320 B8B3F1C0E58C15DB6A81D30C3648A882F4316B9B are the correct ones.

  7. laanwj merged this on Mar 5, 2017
  8. laanwj closed this on Mar 5, 2017

  9. laanwj referenced this in commit ccf5e43ce0 on Mar 5, 2017
  10. MarcoFalke deleted the branch on Mar 5, 2017
  11. MarcoFalke restored the branch on Mar 5, 2017
  12. MarcoFalke deleted the branch on Mar 6, 2017
  13. jonasschnelli commented at 11:09 AM on March 6, 2017: contributor

    Post merge tested ACK 589cd63b303158b565d49d2ce26c9e46b0bba8bd. Verfied sipa's (133EAC179436F14A5CF1B794860FEB804E669320) and MarcoFalkes (B8B3F1C0E58C15DB6A81D30C3648A882F4316B9B ) new key.

  14. MarcoFalke locked this on Sep 8, 2021

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-15 15:15 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me