[UI Styling] Left-Align Tab Bar - optionsdialog.ui #9924

pull SCDeveloper wants to merge 1 commits into bitcoin:master from SCDeveloper:patch-1 changing 1 files +4 −0

SCDeveloper commented at 7:29 PM on March 5, 2017: none

Aesthetics.
[UI Styling] Left-Align Tab Bar
Aesthetics.
464d08912c
SCDeveloper renamed this:
~~[UI Styling] Left-Align Tab Bar~~
[UI Styling] Left-Align Tab Bar - optionsdialog.ui
on Mar 5, 2017
SCDeveloper commented at 7:40 PM on March 5, 2017: none

<img width="627" alt="screen shot 2017-03-05 at 20 40 07" src="https://cloud.githubusercontent.com/assets/13606170/23590637/0331ea9e-01e4-11e7-854e-b1c6838cbb5f.png">
SCDeveloper commented at 8:00 PM on March 5, 2017: none

Merge alongside #9925
luke-jr commented at 8:22 PM on March 5, 2017: member

It's already left-aligned on platforms that use left-aligned tab bars... Your screenshot looks like macOS. Does macOS not match what our tab bar looks like?
SCDeveloper commented at 10:11 PM on March 5, 2017: none

No this is a BUG on OSX, and I have fixed it :D
fanquake added the label GUI on Mar 5, 2017
jonasschnelli commented at 8:29 AM on March 6, 2017: contributor

I don't think we should do this. OSX uses a center-aligned tab-bar.

Example form the settings: <img width="874" alt="bildschirmfoto 2017-03-06 um 09 27 44" src="https://cloud.githubusercontent.com/assets/178464/23602151/4dc29d36-024f-11e7-95f6-012bdd132614.png">
jonasschnelli commented at 8:30 AM on March 6, 2017: contributor

I don't think we should do this. OSX uses a center-aligned tab-bar.

Example form the settings: <img width="874" alt="bildschirmfoto 2017-03-06 um 09 27 44" src="https://cloud.githubusercontent.com/assets/178464/23602151/4dc29d36-024f-11e7-95f6-012bdd132614.png">
SCDeveloper commented at 10:12 AM on March 6, 2017: none

This is the exact reason I changed it, because OSX just centres it, so now I tell it to left-align.

I think you should do this considering that it appears left-aligned on all other operating systems, it also looks a damned sight better.
laanwj commented at 1:28 PM on March 6, 2017: member

I agree with @jonasschnelli, we should simply use the OS-provided layout. On MacOSX it's what users expect.
SCDeveloper commented at 3:05 PM on March 6, 2017: none

I am an OSX user and it isn't what I expected. OK, then let the OS simply control how the application is styled and relinquish control over it. Seems an odd way to go about things. I am going to add those lines to my wallet and keep them there, it simply LOOKS BETTER.
luke-jr commented at 3:29 PM on March 6, 2017: member

OK, then let the OS simply control how the application is styled and relinquish control over it.

That's exactly what we (and any reasonable software) do...
SCDeveloper commented at 3:37 PM on March 6, 2017: none

Even if it looks bad and differs from how it looks on all the other operating systems?
laanwj commented at 3:41 PM on March 6, 2017: member

Even if it looks bad and differs from how it looks on all the other operating systems?

Yes. Why would someone using some platform care how it looks in other platforms at all?
laanwj commented at 3:42 PM on March 6, 2017: member

Closing these, we disagree on the direction the GUI should take so it's not going to go anywhere.
laanwj closed this on Mar 6, 2017
SCDeveloper commented at 3:42 PM on March 6, 2017: none

Because people don't just use one operating system. I have Windows, Linux and OSX.
luke-jr commented at 5:10 PM on March 6, 2017: member

If you dislike how it looks, reconfigure your OS or use one that lets you.
MarcoFalke locked this on Sep 8, 2021

Contributors

Labels