Improve logging in bctest.py if there is a formatting mismatch #9945

pull jnewbery wants to merge 1 commits into bitcoin:master from jnewbery:improve_bctest_logging changing 1 files +9 −3

jnewbery commented at 11:11 PM on March 7, 2017: member

#9032 added format comparison checking to bctest.py.

If the formats don't match, the test doesn't print the difference between the expected output and the actual output, which makes troubleshooting and fixing the test difficult.

This small changes the logic so that if the formatting comparison fails, we go on to compare the data, and then fail the test if either of those comparisons fail.
Improve logging in bctest.py if there is a formatting mismatch 6c1fb73dd1
fanquake added the label Tests on Mar 8, 2017
laanwj commented at 6:18 AM on March 8, 2017: member

utACK https://github.com/bitcoin/bitcoin/pull/9945/commits/6c1fb73dd1744b7281e5d506c14307daf1b72e1f
MarcoFalke commented at 11:12 AM on March 8, 2017: member

utACK 6c1fb73dd1744b7281e5d506c14307daf1b72e1f
MarcoFalke merged this on Mar 8, 2017
MarcoFalke closed this on Mar 8, 2017
MarcoFalke referenced this in commit ac23a7c1f1 on Mar 8, 2017
PastaPastaPasta referenced this in commit f6f829a4de on Jan 2, 2019
PastaPastaPasta referenced this in commit 65ecf5ab0a on Jan 2, 2019
PastaPastaPasta referenced this in commit ef00cc0a6a on Jan 2, 2019
PastaPastaPasta referenced this in commit 8000a8bd34 on Jan 3, 2019
PastaPastaPasta referenced this in commit b14e626fe1 on Jan 21, 2019
PastaPastaPasta referenced this in commit 1c3efde694 on Jan 27, 2019
PastaPastaPasta referenced this in commit c511a93680 on Jan 29, 2019
PastaPastaPasta referenced this in commit dfe76d8606 on Feb 5, 2019
PastaPastaPasta referenced this in commit 973a69640f on Feb 5, 2019
PastaPastaPasta referenced this in commit 2121ba7764 on Feb 5, 2019
zkbot referenced this in commit 44f5ef7c9d on Nov 9, 2020
zkbot referenced this in commit bd5ff7c889 on Nov 9, 2020
MarcoFalke locked this on Sep 8, 2021

Contributors

Labels

Linked (view graph)

#9032 test: Add format-dependent comparison to bctest