This changes tree_sha512sum() to requests the objects for hashing from git instead of from the working tree.
The change should make the process more deterministic (it hashes what will be pushed) and hopefully avoids the frequent miscomputed SHA512's that happen now.
As an added bonus this can now compute treehashes for non-HEAD commits, although this functionality is not used.
This changes tree_sha512sum() to requests the objects for hashing from
git instead of from the working tree.
The change should make the process more deterministic (it hashes what
will be pushed) and hopefully avoids the frequent miscomputed SHA512's
that happen now.
utACK a327e8ea30e10abdce910a3e37c78e00d0918548
On Mon, Mar 13, 2017 at 4:15 PM, Wladimir J. van der Laan notifications@github.com wrote:
This changes tree_sha512sum() to requests the objects for hashing from git instead of from the working tree.
The change should make the process more deterministic (it hashes what will be pushed) and hopefully avoids the frequent miscomputed SHA512's that happen now.
You can view, comment on, or merge this pull request online at:
Commit Summary
devtools: Make github-merge compute SHA512 from git, instead of worktree
File Changes
M contrib/devtools/github-merge.py (45)
Patch Links:
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.
@MarcoFalke thanks I checked this against many recent merge commits and am now confident enough that this computes the same output as the old algorithm, to merge this.