[QT] Show more descriptive label for pay to yourself entries #9985

1. 
   NicolasDorier commented at 4:42 pm on March 13, 2017: contributor

   This show a more descriptive label for Pay To Yourself transaction entries in bitcoin QT. Showing the label of the first Output.

   Before:

   After:

   Pay to yourself is common when using Bitcoin Core for tracking coins going from and to Watch-Only addresses. For example, in the case of TumblerBit, it will make it easier to see when a coins is transitioning throught different states: Wallet =>Alice Escrow => Alice Offer => Alice Offer Redeem.

2. [QT] Show more descriptive label for pay to yourself transaction entries bbfdb8da66
3. NicolasDorier force-pushed on Mar 13, 2017
4. fanquake added the label GUI on Mar 14, 2017
5. 
   laanwj commented at 7:39 am on March 14, 2017: member

   Concept ACK
6. in src/qt/transactionrecord.cpp: in bbfdb8da66

   102@@ -103,8 +103,13 @@ QList<TransactionRecord> TransactionRecord::decomposeTransaction(const CWallet *
   103         {
   104             // Payment to self
   105             CAmount nChange = wtx.GetChange();
   106-
   107-            parts.append(TransactionRecord(hash, nTime, TransactionRecord::SendToSelf, "",
   108+            std::string address;
   109+            CTxDestination destAddress;
   110+            if (wtx.tx->vout.size() >= 1 && ExtractDestination(wtx.tx->vout[0].scriptPubKey, destAddress))
   

   ---

   ---

   

   jonasschnelli commented at 7:45 am on March 14, 2017:

   This list only the first to-yourself-output. But I think this is okay.
7. 
   da2ce7 commented at 0:03 am on March 15, 2017: none

   For ‘send to yourself’ transactions, maybe the row-background shading should be tinted a different colour. So it is more visually apparent what transactions leave the wallet?
8. 
   luke-jr commented at 0:29 am on March 15, 2017: member

   I think it may be a good idea to just remove send-to-self as a thing. In some cases (eg, CoinJoins), it is indistinguishable from send-to-someone-else + receive-from-someone-else in the same transaction…
9. 
   NicolasDorier commented at 2:02 am on March 15, 2017: contributor

   @da2ce7 there is the left column that already have a logo to distinguish. @luke-jr I think this is a good idea, will try that
10. 
    NicolasDorier commented at 2:03 am on March 15, 2017: contributor

    @luke-jr an alternative would be to not consider watch-only as “self”.
11. 
    luke-jr commented at 2:30 am on March 15, 2017: member

    CoinJoins aren’t necessarily watch-only.
12. 
    NicolasDorier commented at 8:27 am on March 16, 2017: contributor

    I think #10007 is superior alternative. Keeping open this one until it is clear we will not use it.
13. NicolasDorier closed this on Jun 12, 2017

    ---

14. DrahtBot locked this on Sep 8, 2021

Contributors
NicolasDorier laanwj jonasschnelli da2ce7 luke-jr

Labels
GUI