tests: Remove unused function dumpKeyInfo #9998

pull kobake wants to merge 1 commits into bitcoin:master from kobake:remove-unused-dump-function changing 1 files +0 −28

kobake commented at 8:34 AM on March 15, 2017: contributor

dumpKeyInfo() is too old. Now the implementation is invalid and the function is not used anywhere.

tests: Remove unused function dumpKeyInfo

dumpKeyInfo() is too old. Now the implementation is invalid and the function is not used anywhere.

4e9f305fe9

kobake force-pushed on Mar 15, 2017
laanwj commented at 12:06 PM on March 15, 2017: member

Now the implementation is invalid

This is clearly dead code and probably it should go. Though it's only in the tests and I can see how this debugging can be useful if you're troubleshooting a test failure. So please add some details on how it is invalid/incompatible now.

MarcoFalke commented at 12:18 PM on March 15, 2017: member

utACK.

It just does not compile:

  CXX      wallet/test/test_test_bitcoin-accounting_tests.o
test/key_tests.cpp: In function ‘void dumpKeyInfo(uint256)’:
test/key_tests.cpp:35:9: error: ‘class CKey’ has no member named ‘resize’; did you mean ‘size’?
     key.resize(32);
         ^~~~~~
test/key_tests.cpp:36:13: error: ‘secret’ was not declared in this scope
     memcpy(&secret[0], &privkey, 32);
             ^~~~~~
test/key_tests.cpp:47:17: error: ‘class CBitcoinSecret’ has no member named ‘SetSecret’
         bsecret.SetSecret(secret, fCompressed);
                 ^~~~~~~~~

kobake commented at 12:34 PM on March 15, 2017: contributor

Yes, the function occurs compiling error if KEY_TESTS_DUMPINFO is defined. The keywords "dumpKeyInfo" and "KEY_TESTS_DUMPINFO" are not found anywhere in the repository except for the key_tests.cpp, so the section is completely dead I judged.
paveljanik commented at 2:08 PM on March 15, 2017: contributor

This is part-duplicate of #9987, please close this PR.
kobake commented at 2:42 PM on March 15, 2017: contributor

Oh, i got it.
kobake closed this on Mar 15, 2017
kobake deleted the branch on Mar 15, 2017
MarcoFalke locked this on Sep 8, 2021

Contributors