Removing “lblGraphRange” minimumSize enables the view to be reduced to the size of a desktop “widget” :)
The peers tab resizes if the detail view is revealed.
Info tab still useful at the “widget” size.
Console tab still functional at “widget” size.
tACK https://github.com/bitcoin-core/gui/pull/291/commits/99f6f43bdd05ed83fca462c0514d6157bad1025b on
Windows 10.
Looks good to me, agree this does look slightly more clean. Other windows seem fine. Before / After screens:
656@@ -657,6 +657,181 @@
657 </item>
658 <item>
659 <layout class="QHBoxLayout" name="horizontalLayout_2">
660+ <item>
661+ <widget class="QGroupBox" name="groupBox_2">
662+ <property name="toolTip">
663+ <string extracomment="Totals"/>
Tested Concept ACK. This seems like a nice design improvement.
Suggest reviewers look at the diff with colorMoved = dimmed-zebra and colorMovedWs = allow-indentation-change.
Is the slider working correctly? It seems like I lose the traffic history if I move it. Edit: bug(?) seems to be the same on current master.
there is plenty of room for more tabs. smile
What I mean is if there’s more data series needed (in addition to “Sent”, and “Received”) on the same graph, not about new tabs.
tACK 1cdcdb30ce57ab3847a839dcb71570c2c5ef0e36
Tested on macOS 11.3 Qt 5.15.2. I agree that this is a better use of space.
@RandyMcMillan
You may want to fix your commit author; it’s currently authored by git. You may want to change that back to you.
@Talkless
What I mean is if there’s more data series needed (in addition to “Sent”, and “Received”) on the same graph, not about new tabs.
That can be figured out when new data series are proposed
~Concept ACK.~ Withdrawn in #291 (comment).
IIUC this is a reincarnation of #90.
0$ git log -1
1commit 1cdcdb30ce57ab3847a839dcb71570c2c5ef0e36 (HEAD -> pr291-0430)
2Author: git <git@gits-Air.deepspace.dynalias.org>
3Date: Mon Sep 14 17:21:44 2020 -0400
4
5 Network Graph layout
^ this (the authorship) should be fixed before merging.
857- </size>
858- </property>
859- <property name="alignment">
860- <set>Qt::AlignCenter</set>
861+ <property name="text">
862+ <string>Range</string>
Why this change?
This label will be overwritten in https://github.com/bitcoin-core/gui/blob/480bf01c295527bd212964efe4df3bb886db5654/src/qt/rpcconsole.cpp#L1006
and it is unnecessary burden to translate the “Range” string.
horizontalLayout_3 is useless now:
With this change
0--- a/src/qt/forms/debugwindow.ui
1+++ b/src/qt/forms/debugwindow.ui
2@@ -642,9 +642,7 @@
3 <attribute name="title">
4 <string>&Network Traffic</string>
5 </attribute>
6- <layout class="QHBoxLayout" name="horizontalLayout_3">
7- <item>
8- <layout class="QVBoxLayout" name="verticalLayout_4">
9+ <layout class="QVBoxLayout" name="verticalLayout_4">
10 <item>
11 <widget class="TrafficGraphWidget" name="trafficGraph" native="true">
12 <property name="sizePolicy">
13@@ -867,8 +865,6 @@
14 </item>
15 </layout>
16 </item>
17- </layout>
18- </item>
19 </layout>
20 </widget>
21 <widget class="QWidget" name="tab_peers">
we have
~Approach ACK 0174e68fd59460b53a187bf396cb54e523185eb1~ Withdrawn in #291 (comment).
A slider glitching was introduced:
I think the root of this bug is the changed layout of the sldGraphRange, lblGraphRange and btnClearTrafficGraph widgets.
On master:
0 <widget class="QLabel" name="lblGraphRange">
1 <property name="minimumSize">
2 <size>
3 <width>100</width>
4 <height>0</height>
5 </size>
6 </property>
7 <property name="alignment">
8 <set>Qt::AlignCenter</set>
9 </property>
10 </widget>
This PR:
0 <widget class="QLabel" name="lblGraphRange">
1 </widget>
What I mean is if there’s more data series needed (in addition to “Sent”, and “Received”) on the same graph, not about new tabs.
That can be figured out when new data series are proposed
So we gonna move back to the right? :) . Maybe adding a splitter, making right pane collapsible would help if someone wants “full screen like” graph?
Update: 1f373f9
Landscape Layout:
Widget Layout:
840 </layout>
841 </widget>
842 </item>
843+ <item>
844+ <widget class="QSlider" name="sldGraphRange">
845+ <property name="minimumSize">
865+ </property>
866+ </widget>
867+ </item>
868+ <item>
869+ <widget class="QLabel" name="lblGraphRange">
870+ <property name="minimumSize">
Slider Issue Fixed:
Concept ACK Tested Successfully on Ubuntu 20.04
The New Layout for the Network Traffic Window looks much better than the current master.
It is also not affecting the functionality of other Node Windows.
Nice Work!
The bug discussed here is also fixed. This was done by op by setting a minimum size of 60px for the lblGraphRange.
But I think op should increase the minimum size a little more because it is causing some overflow issues. Adding a screenshot of the problem:
Overflowing of time (in the blue box near the slider)
Other than this the PR seems to work excellently Adding some screenshots for comparison.
On Maximum Size:
| Master | PR |
|---|---|
 |
 |
On Minimum Size:
| Master | PR |
|---|---|
 |
 |
Difference in Layout (Screenshot from Qt Designer):
| Master | PR |
|---|---|
 |
 |
I’ve reconsidered my opinion, and withdraw my ACKs (https://github.com/bitcoin-core/gui/pull/291#issuecomment-830029755, #291#pullrequestreview-649577005).
Agree with @Talkless’s point (https://github.com/bitcoin-core/gui/pull/291#issuecomment-826322546, #291 (comment), #291 (comment)).
One of such changes, that require the current layout, are “Received” and “Send” counters separated by data type: blocks, transactions, addresses, service messages. Especially, this could be helpful with upcoming Erlay protocol (at least for me, of course).
So, for now, Concept NACK from me.
Can we make it so the default is 3 hours not 30 minutes? Or make it so that this can be configured somewhere?
Also, can we make it so that when the time range is changed that the data is not lost?
726+ <bool>true</bool>
727+ </property>
728+ <layout class="QVBoxLayout" name="verticalLayout_9">
729 <item>
730- <layout class="QHBoxLayout" name="horizontalLayout_4">
731+ <layout class="QHBoxLayout" name="RecievedBox">
Looks good with PR #473 as well…
Minimum size presentation:
Minimum size presentation:
I like this new format - also, it makes it more possible to add a button above/below reset which could be used to toggle between linear and non-linear (rather than clicking on the graph).