English translations update #346

1. 
   hebasto commented at 10:32 am on May 27, 2021: member

   Update for Transifex.

   After changing translator comments in #332 this update will show if Transifex triggers strings to be re-translated.

2. in src/qt/bitcoinstrings.cpp:186 in ed36290725 outdated

   182@@ -189,7 +183,7 @@ QT_TRANSLATE_NOOP("bitcoin-core", "Invalid netmask specified in -whitelist: '%s'
   183 QT_TRANSLATE_NOOP("bitcoin-core", "Loading P2P addresses…"),
   184 QT_TRANSLATE_NOOP("bitcoin-core", "Loading banlist…"),
   185 QT_TRANSLATE_NOOP("bitcoin-core", "Loading block index…"),
   186-QT_TRANSLATE_NOOP("bitcoin-core", "Loading wallet…"),
   187+QT_TRANSLATE_NOOP("bitcoin-core", "Loading wallet..."),
   

   ---

   ---

   

   laanwj commented at 10:33 am on May 27, 2021:

   Strange, why is this changing back

   ---

   

   laanwj commented at 10:35 am on May 27, 2021:

   Looks like bitcoin/bitcoin#20773 accidentally reverted this

   ---

   

   hebasto commented at 10:38 am on May 27, 2021:

   yeah…

   don’t throw a stone at me, but a linter could help

   ---

   

   laanwj commented at 10:40 am on May 27, 2021:

   Please no…

   ---

   

   hebasto commented at 10:52 am on May 27, 2021:

   Fixed in the recent push.
3. scripted-diff: Fix ellipsis after pr20773

   -BEGIN VERIFY SCRIPT-
   sed -i 's|_("Loading wallet...")|_("Loading wallet…")|' src/wallet/*.cpp
   -END VERIFY SCRIPT-

   bfb53ddda9
4. English translations update df4c81fda4
5. in src/qt/bitcoinstrings.cpp:78 in ed36290725 outdated

   74@@ -75,12 +75,6 @@ QT_TRANSLATE_NOOP("bitcoin-core", ""
   75 "Prune: last wallet synchronisation goes beyond pruned data. You need to -"
   76 "reindex (download the whole blockchain again in case of pruned node)"),
   77 QT_TRANSLATE_NOOP("bitcoin-core", ""
   78-"SQLiteDatabase: Failed to prepare the statement to fetch sqlite wallet "
   

   ---

   ---

   

   laanwj commented at 10:36 am on May 27, 2021:

   Nice, this definitely doesn’t need to be translated.
6. hebasto force-pushed on May 27, 2021
7. 
   laanwj commented at 10:58 am on May 27, 2021: member

   ACK df4c81fda490e556775f6006f3d4f7d54f61073b make translate gives me an empty diff
8. 
   jarolrod commented at 12:21 pm on May 27, 2021: member

   ACK df4c81fda490e556775f6006f3d4f7d54f61073b

   Also get an empty diff after running make -C src translate.

9. hebasto merged this on May 27, 2021
10. hebasto closed this on May 27, 2021

    ---

11. hebasto deleted the branch on May 27, 2021
12. hebasto added the label Translations on May 27, 2021
13. sidhujag referenced this in commit e627fe456b on May 27, 2021
14. 
    hebasto commented at 5:42 pm on May 27, 2021: member

    The results of this testing PR.

    In case of changing of translator comments, Transifex:

    • does not change the “Translated” status of the translated string
    • drops the “Reviewed” status of the translated string
15. ryanofsky cross-referenced this on Jun 7, 2021 from issue refactor: remove ::vpwallets and related global variables by ryanofsky
16. gwillen referenced this in commit 013eaeaca2 on Jun 1, 2022
17. bitcoin-core locked this on Aug 16, 2023

Contributors
hebasto laanwj jarolrod

Labels
Translations