Make error message layout consistent #560

1. 
   w0xlt commented at 4:05 am on February 26, 2022: contributor

   Currently, the error message for invalid change address is displayed on the right while in the “Pay to” and “Address” fields do not show the error message, as commented in #553 (comment).

   This PR makes the address error feedback consistent across all fields.

   Supersede #534

   master

   PR

2. gui: make error message layout in `sendcoinsentry` consistent fa3b835e04
3. w0xlt force-pushed on Feb 26, 2022
4. w0xlt force-pushed on Feb 26, 2022
5. gui: make error message layout in `editaddressdialog` consistent 9d75184fe7
6. w0xlt force-pushed on Feb 26, 2022
7. 
   DrahtBot commented at 9:47 pm on February 26, 2022: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   ACK	Rspigler
   Concept ACK	RandyMcMillan

   If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

   Conflicts

   Reviewers, this pull request conflicts with the following ones:

   • #612 (refactor: Drop unused QFrames in SendCoinsEntry by hebasto)
   • #534 (Add translatable address error message by w0xlt)
   • #533 (Add more detailed address error message by w0xlt)

   If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

8. 
   katesalazar commented at 10:13 pm on February 26, 2022: contributor

   I assume in this figure there is a static placeholder for the red label (normally empty):

   

   I assume that’s regular P2WPKH invoice address you are showing.

   Would mean the destination address box be shorter. So what happens if destination address is a longer P2WSH address? Would it then clip while with the current code it would not?

9. jarolrod added the label UI on Mar 10, 2022
10. 
    RandyMcMillan commented at 5:18 pm on May 15, 2022: contributor

    Concept ACK
11. DrahtBot added the label Needs rebase on Jun 21, 2022
12. 
    DrahtBot commented at 10:30 am on June 21, 2022: contributor

    🐙 This pull request conflicts with the target branch and needs rebase.

    Want to unsubscribe from rebase notifications on this pull request? Just convert this pull request to a “draft”.

13. 
    Rspigler commented at 6:30 pm on August 1, 2022: contributor

    tACK commit 9d75184fe7d915e05ac01d50cec90881594ef19a

    Tested all address types in the ‘Pay To’, ‘Custom Change Address’, and ‘New Send Address’ fields.

    Just noting that it says “Warning: Invalid Bitcoin address” immediately, but only highlights red when you click out of the text box. I don’t know if I have a preference there. But I like the change.

    I get this message when opening:

    QVariant::load: unknown user type with name BitcoinUnits::Unit.

14. 
    DrahtBot commented at 10:30 am on October 31, 2022: contributor

    • Is it still relevant? ➡️ Please solve the conflicts to make it ready for review and to ensure the CI passes.
    • Is it no longer relevant? ➡️ Please close.
    • Did the author lose interest or time to work on this? ➡️ Please close it and mark it ‘Up for grabs’ with the label, so that it can be picked up in the future.
15. 
    DrahtBot commented at 0:50 am on January 29, 2023: contributor

    There hasn’t been much activity lately and the patch still needs rebase. What is the status here?

    • Is it still relevant? ➡️ Please solve the conflicts to make it ready for review and to ensure the CI passes.
    • Is it no longer relevant? ➡️ Please close.
    • Did the author lose interest or time to work on this? ➡️ Please close it and mark it ‘Up for grabs’ with the label, so that it can be picked up in the future.
16. 
    hebasto commented at 3:15 pm on March 27, 2023: member

    Closing this due to lack of activity. Feel free to reopen.
17. hebasto closed this on Mar 27, 2023

    ---

18. bitcoin-core locked this on Mar 26, 2024

Contributors
w0xlt DrahtBot katesalazar RandyMcMillan Rspigler hebasto

Labels
Needs rebase UI