Add used balance to overview page #775

pull BrandonOdiwuor wants to merge 1 commits into bitcoin-core:master from BrandonOdiwuor:overview_page_add_used_balance changing 4 files +48 −5
  1. BrandonOdiwuor commented at 8:36 am on November 3, 2023: contributor

    Second part: Fixes #769

    Add used balance to the overview page for wallets with the avoid_reuse flag enabled

    Prerequsite:

    overview page when avoid_reuse is enabled Screenshot from 2023-11-02 18-10-06

    overview page when avoid_reuse is not enabled Screenshot from 2023-11-03 11-07-45

  2. gui: add used balance to overview page
    Add used balance to overview page for wallets with avoid_reuse flag enabled
    d32506b39f
  3. DrahtBot commented at 8:36 am on November 3, 2023: contributor

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Reviews

    See the guideline for information on the review process.

    Type Reviewers
    Concept ACK katesalazar, pablomartin4btc

    If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

  4. DrahtBot added the label CI failed on Nov 3, 2023
  5. in src/qt/forms/overviewpage.ui:187 in d32506b39f
    183+              </property>
    184+              <property name="toolTip">
    185+               <string>Your current used balance</string>
    186+              </property>
    187+              <property name="text">
    188+               <string notr="true">21 000 000.00000000 BTC</string>
    


    katesalazar commented at 6:39 pm on November 6, 2023:
  6. katesalazar commented at 6:41 pm on November 6, 2023: contributor
    Concept ACK
  7. in src/qt/forms/overviewpage.ui:184 in d32506b39f
    180+             <widget class="QLabel" name="labelUsed">
    181+              <property name="cursor">
    182+               <cursorShape>IBeamCursor</cursorShape>
    183+              </property>
    184+              <property name="toolTip">
    185+               <string>Your current used balance</string>
    


    katesalazar commented at 6:53 pm on November 6, 2023:

    Because the space is tiny, and the impact should be big, every word in an effective tooltip needs to pack a punch.

    Source: Internet

    as the tooltip for the “used” line of the “balances” block, “your current used balance” doesnt feel like a great tooltip

  8. hebasto renamed this:
    gui: add used balance to overview page
    Add used balance to overview page
    on Nov 20, 2023
  9. pablomartin4btc commented at 10:49 pm on November 22, 2023: contributor

    Concept ACK

    As mentioned on the first part/ core PR, please consider to add the wallet interface commit as the very first commit here on this PR so it’s easier to test this new feature.

  10. DrahtBot commented at 11:58 am on February 29, 2024: contributor

    🤔 There hasn’t been much activity lately and the CI seems to be failing.

    If no one reviewed the current pull request by commit hash, a rebase can be considered. While the CI failure may be a false positive, the CI hasn’t been running for some time, so there may be a real issue hiding as well. A rebase triggers the latest CI and makes sure that no silent merge conflicts have snuck in.

  11. luke-jr commented at 0:41 am on April 24, 2024: member
    What is the use case here? (And the avoid_reuse flag in general…)
  12. hebasto commented at 2:39 pm on May 12, 2024: member

    @BrandonOdiwuor

    Second part: Fixes #769

    Add used balance to the overview page for wallets with the avoid_reuse flag enabled

    Prerequsite:

    If you are still working on this PR, please address https://github.com/bitcoin/bitcoin/pull/28776#discussion_r1557805199.

  13. BrandonOdiwuor commented at 4:44 pm on May 15, 2024: contributor

    @hebasto Sorry I will be updating the PR description

    There was a change in implementation. I created a different PR (https://github.com/bitcoin/bitcoin/pull/29062) based on the recommendation to refactor the getbalance() function which touches the bitcoin repo. trying to get it merged so that I can update this PR

  14. hebasto commented at 4:54 pm on May 15, 2024: member

    There was a change in implementation. I created a different PR (bitcoin/bitcoin#29062) based on the recommendation to refactor the getbalance() function which touches the bitcoin repo. trying to get it merged so that I can update this PR

    Okay. Until then, marking this PR as a draft.

  15. hebasto marked this as a draft on May 15, 2024
  16. DrahtBot commented at 1:20 am on August 13, 2024: contributor

    🤔 There hasn’t been much activity lately and the CI seems to be failing.

    If no one reviewed the current pull request by commit hash, a rebase can be considered. While the CI failure may be a false positive, the CI hasn’t been running for some time, so there may be a real issue hiding as well. A rebase triggers the latest CI and makes sure that no silent merge conflicts have snuck in.

  17. DrahtBot commented at 1:22 am on November 11, 2024: contributor

    🤔 There hasn’t been much activity lately and the CI seems to be failing.

    If no one reviewed the current pull request by commit hash, a rebase can be considered. While the CI failure may be a false positive, the CI hasn’t been running for some time, so there may be a real issue hiding as well. A rebase triggers the latest CI and makes sure that no silent merge conflicts have snuck in.


github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin-core/gui. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-11-21 12:20 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me